You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/10/01 15:25:00 UTC

[PR] fix(message): grade a missing topic route as empty in the key query path [rocketmq-dashboard]

Frun1na opened a new pull request, #5287:
URL: https://github.com/apache/rocketmq-dashboard/pull/5287

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5286
   
   ### Brief Description
   
   `queryByKey` only graded `ResponseCode.NO_MESSAGE` as business-empty. `MQAdminImpl.queryMessage` throws `MQClientException(TOPIC_NOT_EXIST)` when the topic route is gone (e.g. the topic was just deleted), which fell through to `BusinessException(502)`. The path now grades both codes as empty, matching `queryByTopic` two hunks below and the query failure grading contract.
   
   ### How Did You Test This Change?
   
   ```
   cd server && mvn -B -ntp test -Dtest=RocketMQMessageProviderTest
   
   Tests run: 57, Failures: 0, Errors: 0, Skipped: 0
   BUILD SUCCESS
   ```
   
   
   ---
   
   Re-submission of #4918: the original PR was closed by the stale bot after 7 days without review activity, and GitHub now rejects reopening pull requests in this repository ("state cannot be changed"), so the same change is re-submitted rebased onto the current `rocketmq-studio` tip (`a460673f`). The original review thread stays available at #4918.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(message): grade a missing topic route as empty in the key query path [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #5287:
URL: https://github.com/apache/rocketmq-dashboard/pull/5287#issuecomment-6044115686

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(message): grade a missing topic route as empty in the key query path [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #5287:
URL: https://github.com/apache/rocketmq-dashboard/pull/5287#issuecomment-6093177185

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org