You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by gr...@apache.org on 2011/06/06 12:05:47 UTC
svn commit: r1132572 -
/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
Author: grobmeier
Date: Mon Jun 6 10:05:47 2011
New Revision: 1132572
URL: http://svn.apache.org/viewvc?rev=1132572&view=rev
Log:
LOG4PHP-138: fixed the fix: of course not all appenders need the reference. Just the one object which is actually working on the file. Fixed myself
Modified:
logging/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
Modified: logging/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php?rev=1132572&r1=1132571&r2=1132572&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php (original)
+++ logging/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php Mon Jun 6 10:05:47 2011
@@ -226,38 +226,12 @@ class LoggerAppenderRollingFile extends
if(flock($this->fp, LOCK_EX)) {
if(ftell($this->fp) > $this->getMaxFileSize()) {
$this->rollOver();
- $this->updateLoggers();
}
}
}
}
/**
- * Iterates through all loggers and updates all appenders with a new file name
- */
- private function updateLoggers() {
- $appenders = Logger::getRootLogger()->getAllAppenders();
- $this->updateAppenders($appenders);
- $loggers = Logger::getAllLoggers();
- foreach($loggers as $logger) {
- $appenders = $logger->getAllAppenders();
- $this->updateAppenders($appenders);
- }
- }
-
- /**
- * Updates all appenders with a new file name
- */
- private function updateAppenders($appenders) {
- foreach($appenders as $appender) {
- if($appender instanceof LoggerAppenderRollingFile) {
- $appender->setFile($this->getFile());
- $appender->activateOptions();
- }
- }
- }
-
- /**
* @return Returns the maximum number of backup files to keep around.
*/
public function getMaxBackupIndex() {