You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/09/12 06:26:49 UTC
[GitHub] [openwhisk-runtime-go] dengliming opened a new pull request #131: Rewrord error message on failed init
dengliming opened a new pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131
Fixes [https://github.com/apache/openwhisk-runtime-go/issues/125](https://github.com/apache/openwhisk-runtime-go/issues/125)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] rabbah commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-691505956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-698666101
I think you also need to update the expected test output at https://github.com/apache/openwhisk-runtime-go/blob/master/openwhisk/executor_test.go#L108 to match the changed error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] rabbah commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-691505956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss merged pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dengliming commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
dengliming commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-698692533
@dgrove-oss Thanks. Fixed at lastest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-698666101
I think you also need to update the expected test output at https://github.com/apache/openwhisk-runtime-go/blob/master/openwhisk/executor_test.go#L108 to match the changed error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dengliming commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
dengliming commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-698692533
@dgrove-oss Thanks. Fixed at lastest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] rabbah commented on pull request #131: Rewrord error message on failed init
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #131:
URL: https://github.com/apache/openwhisk-runtime-go/pull/131#issuecomment-691505956
Thanks @dengliming for the contribution 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org