You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/17 16:26:19 UTC

[GitHub] mrutkows commented on issue #2575: Use Configuration File with Scan Code and Add Missing License Header

mrutkows commented on issue #2575: Use Configuration File with Scan Code and Add Missing License Header
URL: https://github.com/apache/incubator-openwhisk/pull/2575#issuecomment-323124331
 
 
   @bjustin-ibm @dubeejw The reason the ASF header was not found by scancode was that the default .cfg excludes (via [Excludes section) all files under any "tests" directory.  This is historical and there was initial pushback at changing this behavior earlier this year.  However, Rodric merged the last PR yesterday (https://github.com/apache/incubator-openwhisk-catalog/pull/229) for Catalog that perhaps would allow us to remove this "tests" folder exclusion from the .cfg file.  
   
   I pulled the latest for ALL repos and ran scancode against it without the "tests" exclusion and it seems to pass.   Would there be any impacts at removing this that I have not foreseen?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services