You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/26 08:11:30 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11659: [Feature][UI] Enable highlight and auto-complete for SQL scripts

EricGao888 commented on code in PR #11659:
URL: https://github.com/apache/dolphinscheduler/pull/11659#discussion_r955779402


##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sql.ts:
##########
@@ -43,6 +43,10 @@ export function useSql(model: { [field: string]: any }): IJsonItem[] {
         trigger: ['input', 'trigger'],
         required: true,
         message: t('project.node.sql_empty_tips')
+      },
+      props: {
+        language: 'sql',
+        placeholder: t('project.node.sql_statement_tips')

Review Comment:
   @Amy0104 Thanks for the information. When I tested it manually, the placeholder didn't take effect. But highlight and auto-complete did work. What about removing the `placeholder` and only keeping the `language`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org