You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Gili (JIRA)" <ji...@apache.org> on 2018/09/08 20:33:00 UTC
[jira] [Commented] (MJLINK-7) Code incorrectly assumes that two
modules won't have the same name
[ https://issues.apache.org/jira/browse/MJLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608197#comment-16608197 ]
Gili commented on MJLINK-7:
---------------------------
[~khmarbaise] You misread the post you linked to. It explicitly states that multiple modules may have the same name so long as they reside within separate directories. This is precisely what I am referring to. Please reopen this issue.
> Code incorrectly assumes that two modules won't have the same name
> ------------------------------------------------------------------
>
> Key: MJLINK-7
> URL: https://issues.apache.org/jira/browse/MJLINK-7
> Project: Maven JLink Plugin
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha-2
> Reporter: Gili
> Assignee: Karl Heinz Marbaise
> Priority: Major
>
> https://github.com/apache/maven-plugins/blob/bfa65c310d7f16671db672773f73fd64f05edfd0/maven-jlink-plugin/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java#L327 wrongfully assumes that two modules won't share the same name (this is legal as discussed at https://stackoverflow.com/a/46573805/14731).
> Please review this code to make sure it correctly handles multiple modules having the same name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)