You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TommiKetola <gi...@git.apache.org> on 2017/02/21 12:24:43 UTC
[GitHub] cordova-plugin-media pull request #129: (android) Fix NullPointerException i...
GitHub user TommiKetola opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/129
(android) Fix NullPointerException in AudioPlayer.readyPlayer
### Platforms affected
Android
### What does this PR do?
Fixes null pointer exception with following path:
#0. Crashed: JavaBridge: 0 0 0x0000000000000000
at java.lang.String.compareTo(String.java)
at org.apache.cordova.media.AudioPlayer.readyPlayer(AudioPlayer.java:583)
at org.apache.cordova.media.AudioPlayer.startPlaying(AudioPlayer.java:299)
at org.apache.cordova.media.AudioHandler.resumeAllGainedFocus(AudioHandler.java:414)
at org.apache.cordova.media.AudioHandler$1.onAudioFocusChange(AudioHandler.java:431)
Mechanism: resumeAllGainedFocus() calls startPlaying(null) and null value is not handled properly in readyPlayer().
### What testing has been done on this change?
Only crash scenario has been tested (performs only extra validation)
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mandorla-fi/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit 872501865da00c476f245d1303507979c46b68ac
Author: Tommi Ketola <to...@keto.la>
Date: 2017-02-21T10:33:21Z
Avoid compareTo exception with null argument.
commit 7e61e1f2aff5abf927b2734cebceda6867279695
Author: Tommi Ketola <to...@keto.la>
Date: 2017-02-21T11:37:47Z
Change more idiomatic.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media issue #129: (android) Fix NullPointerException in Audio...
Posted by TommiKetola <gi...@git.apache.org>.
Github user TommiKetola commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
Looking closer at other pull requests, merging #122 should make this patch unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media issue #129: (android) Fix NullPointerException in Audio...
Posted by ghenry22 <gi...@git.apache.org>.
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
@TommiKetola #122 should catch most scenarios that would cause this one to occur. However, there is no validation that a value is passed in to the method that this PR patches either so there is always the change that we are comparing a NULL to something.
I still think this patch should be included as well so that basic data validation is performed.
@shazron - I have been testing this PR out over the last few days in my own apps and have had no issues. This could be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media issue #129: (android) Fix NullPointerException in Audio...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/129/commits/7e61e1f2aff5abf927b2734cebceda6867279695)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=windows-10-store/artifact/) |
| [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-9.3/artifact/) |
| [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=ios-10.0/artifact/) |
| [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-4.4/artifact/) |
| [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/99//PLATFORM=android-5.1/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media issue #129: (android) Fix NullPointerException in Audio...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
After conferring with @infil00p, I tested with cordova-paramedic, everything passes, so I'm pulling this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request #129: (android) Fix NullPointerException i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org