You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "jonyangx (via GitHub)" <gi...@apache.org> on 2023/02/13 01:09:35 UTC

[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #3119: [ISSUE #3118]Refactor Acl

jonyangx commented on code in PR #3119:
URL: https://github.com/apache/incubator-eventmesh/pull/3119#discussion_r1103913879


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/acl/Acl.java:
##########
@@ -26,14 +26,25 @@
 import org.apache.commons.lang3.StringUtils;
 
 import java.util.Properties;
-import java.util.ServiceLoader;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class Acl {
+
     private static final Logger logger = LoggerFactory.getLogger(Acl.class);

Review Comment:
   Simplify code using Lombok @Slf4j.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org