You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/21 03:02:20 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request, #18146: [fix][ci] Fix checkstyle issue.
Technoboy- opened a new pull request, #18146:
URL: https://github.com/apache/pulsar/pull/18146
### Motivation
```
There are 2 errors reported by Checkstyle 8.37 with /Users/tboy/tboy/workspace_1/pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java:[28,8] (imports) UnusedImports: Unused import: java.util.ArrayList.
[ERROR] src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java:[337] (sizes) LineLength: Line is longer than 120 characters (found 139).
```
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #18146: [fix][build] Fix checkstyle issue.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #18146:
URL: https://github.com/apache/pulsar/pull/18146#issuecomment-1286423083
> @Technoboy- @mattisonchao @codelipenghui @poorbarcode I suggest we proceed with #18142 to resolve checkstyle issues globally since it adds a CI task to prevent regression.
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #18146: [fix][build] Fix checkstyle issue.
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18146: [fix][build] Fix checkstyle issue.
URL: https://github.com/apache/pulsar/pull/18146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18146: [fix][build] Fix checkstyle issue.
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18146:
URL: https://github.com/apache/pulsar/pull/18146#issuecomment-1286416722
@Technoboy- @mattisonchao @codelipenghui @poorbarcode I suggest we proceed with #18142 to resolve checkstyle issues globally since it adds a CI task to prevent regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org