You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2016/12/13 21:33:37 UTC
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1327
NIFI-3194: PutElasticsearchHttp should route flowfiles to failure on connection errors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3194
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1327
----
commit 1eba4d5f895d35c5236a84990d29cfe3675bfc66
Author: Matt Burgess <ma...@apache.org>
Date: 2016-12-13T21:26:32Z
NIFI-3194: Unit test showing PutESHttp bug
commit 9abfdb386c7d6df3c50d3d48e1b40621459858fb
Author: Matt Burgess <ma...@apache.org>
Date: 2016-12-13T21:27:52Z
NIFI-3194: Fixed error handling in PutElasticsearchHttp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1327#discussion_r93095656
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java ---
@@ -321,9 +321,16 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final Response getResponse;
try {
getResponse = sendRequestToElasticsearch(okHttpClient, url, username, password, "PUT", requestBody);
- } catch (IllegalStateException | IOException ioe) {
- throw new ProcessException(ioe);
+ } catch (final Exception e) {
+ logger.error("Routing to {} due to exception: {}", new Object[]{REL_FAILURE.getName(), e}, e);
+ flowFilesToTransfer.forEach((flowFileToTransfer) -> {
+ flowFileToTransfer = session.penalize(flowFileToTransfer);
--- End diff --
Rgr. as long as there is reasoning
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1327: NIFI-3194: PutElasticsearchHttp should route flowfiles to ...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1327
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1327#discussion_r93093642
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java ---
@@ -321,9 +321,16 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final Response getResponse;
try {
getResponse = sendRequestToElasticsearch(okHttpClient, url, username, password, "PUT", requestBody);
- } catch (IllegalStateException | IOException ioe) {
- throw new ProcessException(ioe);
+ } catch (final Exception e) {
--- End diff --
I couldn't see any in the various calls that are made in that method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1327#discussion_r93070476
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java ---
@@ -321,9 +321,16 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final Response getResponse;
try {
getResponse = sendRequestToElasticsearch(okHttpClient, url, username, password, "PUT", requestBody);
- } catch (IllegalStateException | IOException ioe) {
- throw new ProcessException(ioe);
+ } catch (final Exception e) {
--- End diff --
Will there be any exceptions encountered here where we would want to route to RETRY instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1327: NIFI-3194: PutElasticsearchHttp should route flowfiles to ...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1327
+1
Visually verified code and did a contrib-check build. In a standalone instance, tested many different variations of misconfigured PutES processor hitting ES 2.3.3 and all worked as expected (routing to failure/retry). Thanks @mattyb149 I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1327#discussion_r93094070
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java ---
@@ -321,9 +321,16 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final Response getResponse;
try {
getResponse = sendRequestToElasticsearch(okHttpClient, url, username, password, "PUT", requestBody);
- } catch (IllegalStateException | IOException ioe) {
- throw new ProcessException(ioe);
+ } catch (final Exception e) {
+ logger.error("Routing to {} due to exception: {}", new Object[]{REL_FAILURE.getName(), e}, e);
+ flowFilesToTransfer.forEach((flowFileToTransfer) -> {
+ flowFileToTransfer = session.penalize(flowFileToTransfer);
--- End diff --
I think it was because the processor couldn't tell from the exception whether it could/should be handled as a retry or failure, so I just penalized it and sent it to failure. I can change it if that's not the best way to handle it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1327#discussion_r93070719
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java ---
@@ -321,9 +321,16 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final Response getResponse;
try {
getResponse = sendRequestToElasticsearch(okHttpClient, url, username, password, "PUT", requestBody);
- } catch (IllegalStateException | IOException ioe) {
- throw new ProcessException(ioe);
+ } catch (final Exception e) {
+ logger.error("Routing to {} due to exception: {}", new Object[]{REL_FAILURE.getName(), e}, e);
+ flowFilesToTransfer.forEach((flowFileToTransfer) -> {
+ flowFileToTransfer = session.penalize(flowFileToTransfer);
--- End diff --
Why penalize when routing to failure? My view of penalization is that it should only be used when the flowfile failed to process at this time but if processed again at a later time it may succeed (ie. a RETRY).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---