You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "mayankshriv (via GitHub)" <gi...@apache.org> on 2024/06/21 14:28:10 UTC
[I] EXPR_MIN/MAX do not work [pinot]
mayankshriv opened a new issue, #13452:
URL: https://github.com/apache/pinot/issues/13452
It seems that the `EXPR_MIN/MAX` functions do not work in both v1 and v2 query engines.
Running a simple query like below errors out, even though there is no alias in the query. On debugging, I see that the query never gets rewritten as ExprMinMaxRewriter is not hooked up. I could also not find any config where the rewriter could be configured.
* Any reason to not hookup the rewriter by default so the query can work?
* If there's one, how does one hook that rewriter up, is there a config?
```
SELECT
EXPR_MAX(balance,block_number)
FROM org_2dYiMRMfas142XRKQ3bJIqmN3V6_base_erc20_balance_changes_block_v2_edea23a753f94dceae4c2b6d3fff50bd
WHERE token_address = lower('0x4200000000000000000000000000000000000006')
Query execution error on: Server_pinot-server-5.pinot-server-headless.pinot.svc.cluster.local_8098 org.apache.pinot.spi.exception.BadQueryRequestException: Invalid aggregation function: exprmax(balance,block_number); Reason: Aggregation function: EXPRMAX is only supported in selection without alias.
```
cc: @jasperjiaguo @siddharthteotia @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] The aggregation functions EXPR_MIN/MAX do not seem to work. [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13452:
URL: https://github.com/apache/pinot/issues/13452#issuecomment-5223454794
This issue has been closed because it has been inactive for 180 days. If you believe this issue is still relevant, please feel free to reopen it or create a new issue. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] The aggregation functions EXPR_MIN/MAX do not seem to work. [pinot]
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia commented on issue #13452:
URL: https://github.com/apache/pinot/issues/13452#issuecomment-2197766238
@jasperjiaguo recently fixed a bug in this functionality that we had discovered from an internally deployed use case.
Jia - is this a different problem ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] The aggregation functions EXPR_MIN/MAX do not seem to work. [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13452: The aggregation functions EXPR_MIN/MAX do not seem to work.
URL: https://github.com/apache/pinot/issues/13452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] The aggregation functions EXPR_MIN/MAX do not seem to work. [pinot]
Posted by "jasperjiaguo (via GitHub)" <gi...@apache.org>.
jasperjiaguo commented on issue #13452:
URL: https://github.com/apache/pinot/issues/13452#issuecomment-2292481646
`EXPRMAX is only supported in selection without alias` is a know limitation and is called out in the design/user guide. Because this feature relies on query result rewriting to work, we could not use alias with it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] The aggregation functions EXPR_MIN/MAX do not seem to work. [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13452:
URL: https://github.com/apache/pinot/issues/13452#issuecomment-4823460649
This issue has been automatically marked as stale because it has not had any activity in the last 150 days. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org