You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pascal Borreli <pa...@borreli.com> on 2013/04/12 06:00:25 UTC
Review Request: Fixed typo in public class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10427/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Fixed typo in public class, made a Review Board with only that as it could be problematic (BC, external class using it)
Diffs
-----
client/WEB-INF/classes/resources/messages_de_DE.properties 5c7fc63
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 70660d2
Diff: https://reviews.apache.org/r/10427/diff/
Testing
-------
Thanks,
Pascal Borreli
Re: Review Request: Fixed typo in public class
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10427/#review19050
-----------------------------------------------------------
Looks good, but adding Chip as it's for 4.1 branch.
- Rohit Yadav
On April 12, 2013, 4 a.m., Pascal Borreli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10427/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 4 a.m.)
>
>
> Review request for cloudstack, Joe Brockmeier and Sebastien Goasguen.
>
>
> Description
> -------
>
> Fixed typo in public class, made a Review Board with only that as it could be problematic (BC, external class using it)
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages_de_DE.properties 5c7fc63
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
> engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 70660d2
>
> Diff: https://reviews.apache.org/r/10427/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pascal Borreli
>
>
Re: Review Request: Fixed typo in public class
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10427/#review19071
-----------------------------------------------------------
Ship it!
committed to 4.1 and master. Thanks!
- Chip Childers
On April 12, 2013, 4:11 a.m., Pascal Borreli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10427/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 4:11 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Joe Brockmeier, and Sebastien Goasguen.
>
>
> Description
> -------
>
> Fixed typo in public class, made a Review Board with only that as it could be problematic (BC, external class using it)
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages_de_DE.properties 5c7fc63
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
> engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 70660d2
>
> Diff: https://reviews.apache.org/r/10427/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pascal Borreli
>
>
Re: Review Request: Fixed typo in public class
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10427/
-----------------------------------------------------------
(Updated April 12, 2013, 4:11 a.m.)
Review request for cloudstack, Chip Childers, Joe Brockmeier, and Sebastien Goasguen.
Description
-------
Fixed typo in public class, made a Review Board with only that as it could be problematic (BC, external class using it)
Diffs
-----
client/WEB-INF/classes/resources/messages_de_DE.properties 5c7fc63
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 70660d2
Diff: https://reviews.apache.org/r/10427/diff/
Testing
-------
Thanks,
Pascal Borreli
Re: Review Request: Fixed typo in public class
Posted by Pascal Borreli <pa...@borreli.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10427/
-----------------------------------------------------------
(Updated April 12, 2013, 4 a.m.)
Review request for cloudstack, Joe Brockmeier and Sebastien Goasguen.
Description
-------
Fixed typo in public class, made a Review Board with only that as it could be problematic (BC, external class using it)
Diffs
-----
client/WEB-INF/classes/resources/messages_de_DE.properties 5c7fc63
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 70660d2
Diff: https://reviews.apache.org/r/10427/diff/
Testing
-------
Thanks,
Pascal Borreli