You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/10/26 13:18:38 UTC
[incubator-superset] branch hugh/so-1118 created (now b823ade)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch hugh/so-1118
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.
at b823ade change ordering of btn menu
This branch includes the following new commits:
new b823ade change ordering of btn menu
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[incubator-superset] 01/01: change ordering of btn menu
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/so-1118
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit b823ade28f8def5cee45073a4aa622f5e609fa18
Author: hughhhh <hu...@gmail.com>
AuthorDate: Mon Oct 26 09:18:05 2020 -0400
change ordering of btn menu
---
.../src/explore/components/controls/DatasourceControl.jsx | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
index 709a927..1d70249 100644
--- a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
+++ b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
@@ -194,6 +194,11 @@ class DatasourceControl extends React.PureComponent {
const datasourceMenu = (
<Menu onClick={this.handleMenuItemClick}>
+ {this.props.isEditable && (
+ <Menu.Item key={EDIT_DATASET} data-test="edit-dataset">
+ {t('Edit Dataset')}
+ </Menu.Item>
+ )}
<Menu.Item key={CHANGE_DATASET}>{t('Change Dataset')}</Menu.Item>
<Menu.Item key={EXPLORE_IN_SQL_LAB}>
<a
@@ -201,14 +206,9 @@ class DatasourceControl extends React.PureComponent {
target="_blank"
rel="noopener noreferrer"
>
- {t('Explore in SQL Lab')}
+ {t('View in SQL Lab')}
</a>
</Menu.Item>
- {this.props.isEditable && (
- <Menu.Item key={EDIT_DATASET} data-test="edit-dataset">
- {t('Edit Dataset')}
- </Menu.Item>
- )}
</Menu>
);