[GitHub] clintropolis commented on issue #6588: autosize processing buffers based on direct memory sizing by default

[GitBox <gi...@apache.org>]

clintropolis commented on issue #6588: autosize processing buffers based on direct memory sizing by default
URL: https://github.com/apache/incubator-druid/pull/6588#issuecomment-437494777
 
 
   > I have seen users set maxDirectMemory to arbitrary high values when they get the error that we have for not enough memory available. This change can potentially break such clusters.
   > 
   > I think to make it more useful we need to also have a upper threshold on the calculated values.
   
   It does have an [upper threshold of 2GiB](https://github.com/apache/incubator-druid/pull/6588/files#diff-92edb0e55ced854443349a5580d48257R65), is this too large?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org