You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/23 17:45:31 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3173: Add `RowSelection::iter()`, `Into>` and example

alamb commented on code in PR #3173:
URL: https://github.com/apache/arrow-rs/pull/3173#discussion_r1030732878


##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -347,6 +370,12 @@ impl RowSelection {
         }
         self
     }
+
+    /// Returns an iterator over the [`RowSelector`]s for this
+    /// [`RowSelection`].
+    pub fn iter(&self) -> impl Iterator<Item = &RowSelector> {
+        self.selectors.iter()

Review Comment:
   Is there any reason to copy the RowSelectors around? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org