You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/15 05:44:16 UTC
[PR] fix(settings): disable stale data source actions [rocketmq-dashboard]
Loyal-Young opened a new pull request, #6711:
URL: https://github.com/apache/rocketmq-dashboard/pull/6711
## What is the purpose of the change
Fixes #6710. The Data Sources table can temporarily show rows from a previous search, filter, or page. Edit, Delete, Test Connection, and Export were still available against that stale view.
## Brief changelog
- Track which query produced the loaded rows and disable row actions and export until it matches the active query.
- Keep those actions disabled while a typed search is waiting for its debounce; guard event handlers as well as buttons, including a delete confirmation opened before the query changes.
- Reset the loaded-query marker when a list request fails.
## Verification
- Reproduced the bug with a test that failed because Edit remained enabled immediately after a search change.
- The full DataSourceTab test suite passed (20 tests), plus app TypeScript, changed-file ESLint, and `git diff --check`.
## AI assistance
AI assistance helped trace the table's asynchronous query state and draft the regression. I reviewed the UI guard and checked the failing and passing test runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): disable stale data source actions [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #6711:
URL: https://github.com/apache/rocketmq-dashboard/pull/6711#issuecomment-6261574438
Progress update (2026-10-19): GitHub currently reports the branch as mergeable. All five current CI checks pass. The change is ready for maintainer review. I will follow up on any new feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): disable stale data source actions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6711:
URL: https://github.com/apache/rocketmq-dashboard/pull/6711#issuecomment-6264570898
Folded into #6703, merged into `rocketmq-studio` as 86aa49c34 — your change is in that commit and stays authored by you.
We batched six related message-history / import / LiteTopic / settings PRs (#6703 #5790 #6705 #6721 #6711 #5798) into a single integration commit to keep the history readable, so this one is closed as folded rather than merged separately. No action needed; the linked issue is closed as resolved by #6703.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): disable stale data source actions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6711: fix(settings): disable stale data source actions
URL: https://github.com/apache/rocketmq-dashboard/pull/6711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org