You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HiuKwok (via GitHub)" <gi...@apache.org> on 2024/03/31 09:19:30 UTC
[PR] [SPARK-42846][SQL] Integrate _LEGACY_ERROR_TEMP_2011 into UNEXPECTED_DATA_TYPE [spark]
HiuKwok opened a new pull request, #45786:
URL: https://github.com/apache/spark/pull/45786
### What changes were proposed in this pull request?
This PR proposes to replace _LEGACY_ERROR_TEMP_1003 with UNEXPECTED_DATA_TYPE, as part of the parent initiative of SPARK-37935
### Why are the changes needed?
To rename the legacy error class as part of the refactoring effort, and simplify Spark's error handling aspect.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests
### Was this patch authored or co-authored using generative AI tooling?
No
I have tried to test `QueryExecutionErrors.typeUnsupportedError` also. Still, by understanding the SQL module code base better, seem there is no way to do that, as all inferred types generated by `inferPartitionColumnValue( )` are already covered by `castPartValueToDesiredType( )`.
Also, I have tried the approach of custom type, but by doing so `castPartValueToDesiredType( )` will be skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42846][SQL] Integrate _LEGACY_ERROR_TEMP_2011 into UNEXPECTED_DATA_TYPE [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on PR #45786:
URL: https://github.com/apache/spark/pull/45786#issuecomment-2076080001
@MaxGekk Hi, would you mind having a look at this?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org