You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2025/07/20 23:40:27 UTC
[PR] Add podman support [polaris]
MonkeyCanCode opened a new pull request, #2143:
URL: https://github.com/apache/polaris/pull/2143
Similar to https://github.com/apache/polaris/pull/2051/files, this PR add support for podman for python client regeneration script. Also, as `DOCKER` seems to be preferred, I changed the `Makefile` to use the same to avoid confusion later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add podman support [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2143:
URL: https://github.com/apache/polaris/pull/2143#discussion_r2219769340
##########
client/templates/regenerate.sh:
##########
@@ -20,6 +20,8 @@
set -e
+[[ -z ${DOCKER} ]] && DOCKER="$(which podman > /dev/null && echo podman || echo docker)"
Review Comment:
thx, all clear now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add podman support [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #2143:
URL: https://github.com/apache/polaris/pull/2143#discussion_r2219619429
##########
client/templates/regenerate.sh:
##########
@@ -20,6 +20,8 @@
set -e
+[[ -z ${DOCKER} ]] && DOCKER="$(which podman > /dev/null && echo podman || echo docker)"
Review Comment:
so `DOCKER` here refs to the variable name used in the Makefile as well as those script to change (people can use this variable to set to podman etc. in the current Makefile, I am using `CONTAINER_TOOL` as oppose to `DOCKER` to avoid confusion). But from the other PR with @snazy, podman is more preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add podman support [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode merged PR #2143:
URL: https://github.com/apache/polaris/pull/2143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add podman support [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2143:
URL: https://github.com/apache/polaris/pull/2143#discussion_r2219607410
##########
client/templates/regenerate.sh:
##########
@@ -20,6 +20,8 @@
set -e
+[[ -z ${DOCKER} ]] && DOCKER="$(which podman > /dev/null && echo podman || echo docker)"
Review Comment:
nit: Comments say `docker` is preferred, but this logic prefers `podman` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org