You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/28 14:11:50 UTC
Review Request 27281: Add UI unit tests for Slider View controllers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27281/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-8000
https://issues.apache.org/jira/browse/AMBARI-8000
Repository: ambari
Description
-------
Cover the following files with unit tests:
* controllers/create_app_wizard_controller.js
* controllers/slider_app_controller.js
* controllers/slider_apps_controller.js
* controllers/slider_controller.js
Diffs
-----
contrib/views/slider/src/main/resources/ui/test/unit/controllers/create_app_wizard_controller_test.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js 2f9512c
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_apps_controller_test.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0ec84c8
contrib/views/slider/src/main/resources/ui/test/unit/views/common/table_view_test.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js d287d7f
Diff: https://reviews.apache.org/r/27281/diff/
Testing
-------
Thanks,
Aleksandr Kovalenko
Re: Review Request 27281: Add UI unit tests for Slider View
controllers
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27281/#review58794
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 28, 2014, 1:12 п.п., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27281/
> -----------------------------------------------------------
>
> (Updated Окт. 28, 2014, 1:12 п.п.)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-8000
> https://issues.apache.org/jira/browse/AMBARI-8000
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover the following files with unit tests:
>
> * controllers/create_app_wizard_controller.js
> * controllers/slider_app_controller.js
> * controllers/slider_apps_controller.js
> * controllers/slider_controller.js
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/create_app_wizard_controller_test.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js 2f9512c
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_apps_controller_test.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0ec84c8
> contrib/views/slider/src/main/resources/ui/test/unit/views/common/table_view_test.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js d287d7f
>
> Diff: https://reviews.apache.org/r/27281/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>
Re: Review Request 27281: Add UI unit tests for Slider View
controllers
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27281/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 1:12 p.m.)
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-8000
https://issues.apache.org/jira/browse/AMBARI-8000
Repository: ambari
Description
-------
Cover the following files with unit tests:
* controllers/create_app_wizard_controller.js
* controllers/slider_app_controller.js
* controllers/slider_apps_controller.js
* controllers/slider_controller.js
Diffs
-----
contrib/views/slider/src/main/resources/ui/test/unit/controllers/create_app_wizard_controller_test.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js 2f9512c
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_apps_controller_test.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0ec84c8
contrib/views/slider/src/main/resources/ui/test/unit/views/common/table_view_test.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js d287d7f
Diff: https://reviews.apache.org/r/27281/diff/
Testing
-------
Thanks,
Aleksandr Kovalenko