You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "florianMo (via GitHub)" <gi...@apache.org> on 2024/03/13 17:08:12 UTC

[PR] Fixed: Support "text" attribute on hyperlinks in forms [ofbiz-framework]

florianMo opened a new pull request, #725:
URL: https://github.com/apache/ofbiz-framework/pull/725

   Fixed: OFBIZ-12940
   
   Explanation
   "text" attribute on hyperlinks in forms should define the modal title when used in "layered-modal" mode. Code indicates this intention (OfbizUtil.js, HtmlFormMacroLibrary.ftl) but the makeHyperlinkString Freemarker macro and the form renderer don't process this parameter. This commit fixes the modal title behavior in this context.
   
   Thanks:
   Néréide team
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: Support "text" attribute on hyperlinks in forms (OFBIZ-12940) [ofbiz-framework]

Posted by "florianMo (via GitHub)" <gi...@apache.org>.

florianMo commented on PR #725:
URL: https://github.com/apache/ofbiz-framework/pull/725#issuecomment-2541102275

   already merged by @gilPts 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: Support "text" attribute on hyperlinks in forms [ofbiz-framework]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.

sonarcloud[bot] commented on PR #725:
URL: https://github.com/apache/ofbiz-framework/pull/725#issuecomment-1995028551

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=725) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=725&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=725&metric=new_accepted_issues&view=list)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=725&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Duplication  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=725)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: Support "text" attribute on hyperlinks in forms (OFBIZ-12940) [ofbiz-framework]

Posted by "florianMo (via GitHub)" <gi...@apache.org>.

florianMo closed pull request #725: Fixed: Support "text" attribute on hyperlinks in forms (OFBIZ-12940)
URL: https://github.com/apache/ofbiz-framework/pull/725


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org