[GitHub] [incubator-pinot] mayankshriv commented on pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

[GitBox <gi...@apache.org>]

mayankshriv commented on pull request #6004:
URL: https://github.com/apache/incubator-pinot/pull/6004#issuecomment-700811748


   > What's the motivation to add a new aggregation function as opposed to enhancing the existing one? Is there a backward compatibility issue? If not, it adds more confusion on the user side to have multiple variations of the same aggregation functions.
   
   We discussed offline and did some performance benchmark to ensure there is no regression. Based on the testing/benchmarking results, we decided to move the code under existing function instead of creating a new one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org