You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/10 19:58:33 UTC

[GitHub] [airflow] potiuk opened a new pull request, #26333: Convert all other providers and their tests to __future__.annotations

potiuk opened a new pull request, #26333:
URL: https://github.com/apache/airflow/pull/26333

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #26333: Convert all other providers and their tests to __future__.annotations

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26333:
URL: https://github.com/apache/airflow/pull/26333#issuecomment-1245284684

   Closing as this one will be merged as part of #26289 #26290. See https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp for details


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #26333: Convert all other providers and their tests to __future__.annotations

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26333:
URL: https://github.com/apache/airflow/pull/26333#issuecomment-1243630200

   That's why I also had this "tests" as one big - to compress number of PRs a bit - the "test" changes are quite a bit safer than the "code" changes - basically - if the tests run and are green the tests change is "GOOD". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #26333: Convert all other providers and their tests to __future__.annotations

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #26333: Convert all other providers and their tests to __future__.annotations
URL: https://github.com/apache/airflow/pull/26333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #26333: Convert all other providers and their tests to __future__.annotations

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26333:
URL: https://github.com/apache/airflow/pull/26333#issuecomment-1243628896

   > TIL that as well as large file diffs, that if you have too many diffs in a PR that GH hides many of the changes too 😁
   > 
   > Also hooo boy! TP was right. If all the PRs were like this then they would be almost impossible to actually review, where as I have been able to review everything so far.
   
   Absolutely :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org