You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/27 23:35:24 UTC

[jira] [Commented] (APEXCORE-627) Unit test AtMostOnceTest intermittently fails

    [ https://issues.apache.org/jira/browse/APEXCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843654#comment-15843654 ] 

ASF GitHub Bot commented on APEXCORE-627:
-----------------------------------------

GitHub user sgolovko opened a pull request:

    https://github.com/apache/apex-core/pull/460

    APEXCORE-627 : Unit test AtMostOnceTest intermittently fails

    Fixed a race problem for calling checkpointed and committed in RecoverableInputOperator. The original implementation of the class used the method checkpointed() of the interface CheckpointListener to refresh a value of one of the criteria variables checkpointedWindowId. The fix update uses the method beforeCheckpoint() of the interface CheckpointNotificationListener. It guaranties that the update of the variable checkpointedWindowId will be done before the call of the method committed().

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgolovko/apex-core APEXCORE-627

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-core/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #460
    
----
commit 0c7e091e1bede9b70768bc91b5ee86a6b15f1a9a
Author: Sergey Golovko <se...@datatorrent.com>
Date:   2017-01-27T23:15:09Z

    APEXCORE-627 : Unit test AtMostOnceTest intermittently fails
    
    Fixed a race problem for calling checkpointed and committed in RecoverableInputOperator. The original implementation of the class used the method checkpointed() of the interface CheckpointListener to refresh a value of one of the criteria variables checkpointedWindowId. The fix update uses the method beforeCheckpoint() of the interface CheckpointNotificationListener. It guaranties that the update of the variable checkpointedWindowId will be done before the call of the method committed().

----


> Unit test AtMostOnceTest intermittently fails
> ---------------------------------------------
>
>                 Key: APEXCORE-627
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-627
>             Project: Apache Apex Core
>          Issue Type: Bug
>         Environment: The test is reproducible on macOS Sierra, Processor 2.2 GHz Intel Core i7, Memory 16GB 1600 MHz DDR3.
>            Reporter: Sergey Golovko
>            Assignee: Sergey Golovko
>            Priority: Minor
>
> The test AtMostOnceTest is not able to reach the criteria to stop the test. And it continue to recover an input operator and rerun the test in a loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)