You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/07/10 15:15:46 UTC

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4112#discussion_r126451783
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java ---
    @@ -61,7 +60,9 @@ public NettyBufferPool(int numberOfArenas) {
     		checkArgument(numberOfArenas >= 1, "Number of arenas");
     		this.numberOfArenas = numberOfArenas;
     
    -		if (!PlatformDependent.hasUnsafe()) {
    +		try {
    +			Class.forName("sun.misc.Unsafe");
    +		} catch (ClassNotFoundException e) {
    --- End diff --
    
    After checking with @StefanRRichter, it seems this check is unnecessary anyway since `org.apache.flink.core.memory.MemoryUtils#UNSAFE` is getting the class if needed and if not existing, Flink should not start anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---