You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/03 18:08:25 UTC
[GitHub] [hadoop] szetszwo commented on a change in pull request #2175: HDFS-15497. Make snapshot limit on global as well per snapshot root directory configurable
szetszwo commented on a change in pull request #2175:
URL: https://github.com/apache/hadoop/pull/2175#discussion_r464571396
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
##########
@@ -99,13 +99,15 @@
private boolean allowNestedSnapshots = false;
private int snapshotCounter = 0;
+ private final int maxSnapshotLimitPerDirectory;
Review comment:
Let's keep using maxSnapshotLimit for per directory limit and add a new variable for the new filesystem limit so that it is consistent with the conf.
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
##########
@@ -498,9 +498,14 @@
public static final int
DFS_NAMENODE_SNAPSHOT_DIFF_LISTING_LIMIT_DEFAULT = 1000;
- public static final String DFS_NAMENODE_SNAPSHOT_MAX_LIMIT =
- "dfs.namenode.snapshot.max.limit";
+ public static final String
+ DFS_NAMENODE_SNAPSHOT_MAX_LIMIT = "dfs.namenode.snapshot.max.limit";
Review comment:
Yes, we cannot change config names.
BTW, please revert the white space change so that it will be easier to back port.
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
##########
@@ -498,9 +498,14 @@
public static final int
DFS_NAMENODE_SNAPSHOT_DIFF_LISTING_LIMIT_DEFAULT = 1000;
- public static final String DFS_NAMENODE_SNAPSHOT_MAX_LIMIT =
- "dfs.namenode.snapshot.max.limit";
+ public static final String
+ DFS_NAMENODE_SNAPSHOT_MAX_LIMIT = "dfs.namenode.snapshot.max.limit";
public static final int DFS_NAMENODE_SNAPSHOT_MAX_LIMIT_DEFAULT = 65536;
+ public static final String
+ DFS_NAMENODE_SNAPSHOT_GLOBAL_LIMIT = "dfs.namenode.snapshot.global.limit";
Review comment:
Let's call this filesystem.limit? Since there are multiple datacenter settings, "global" may be confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org