You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Chris A. Mattmann (JIRA)" <ji...@apache.org> on 2013/08/29 06:28:52 UTC
[jira] [Created] (RAT-148) LicenseAddingReport#report has useless
call to metaData.getData
Chris A. Mattmann created RAT-148:
-------------------------------------
Summary: LicenseAddingReport#report has useless call to metaData.getData
Key: RAT-148
URL: https://issues.apache.org/jira/browse/RAT-148
Project: Apache Rat
Issue Type: Bug
Components: reports
Reporter: Chris A. Mattmann
Fix For: 0.9
While perusing the current trunk code, I noticed that LicenseAddingReport.java#report has a useless call to metaData.getData:
{code:java}
public class LicenseAddingReport extends AbstractReport {
private final AbstractLicenceAppender appender;
public LicenseAddingReport(String pCopyrightMsg, boolean pForced) {
appender = pCopyrightMsg == null ? new ApacheV2LicenceAppender() : new ApacheV2LicenceAppender(pCopyrightMsg);
appender.setForce(pForced);
}
@Override
public void report(org.apache.rat.api.Document document) throws RatException {
final MetaData metaData = document.getMetaData();
final Datum licenseHeader = metaData.get(MetaData.RAT_URL_HEADER_CATEGORY);
if (licenseHeader == null
|| MetaData.RAT_LICENSE_FAMILY_CATEGORY_DATUM_UNKNOWN.getValue().equals(licenseHeader.getValue())) {
final File file = new File(document.getName());
if (file.isFile()) {
try {
appender.append(file);
} catch (IOException e) {
throw new RatException(e.getMessage(), e);
}
}
}
metaData.getData();
}
}
{code}
Looks to me that metaData is a local final variable, and that the call to getData returns a MetaData object, which in turn is never used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira