You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/17 03:00:17 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #881: [WIP] Implement the command `hello`

git-hulk commented on PR #881:
URL: https://github.com/apache/incubator-kvrocks/pull/881#issuecomment-1249985088

   Hi, @mapleFU, many thanks for your contribution.
   
   > I don't know if I need to implement the logic about authentication.
   
   Yes, but there's a bit different in Kvrocks since it has NOT username, so we can always ignore the username. For the auth logic can see [redis_cmd.cc#L78](https://github.com/apache/incubator-kvrocks/blob/unstable/src/redis_cmd.cc#L78).
   
   > I don't know how to write some returning code like "sentinel", "version"
   
   Can ignore those sentinel fields since we are never running in sentinel mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org