You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/28 08:38:43 UTC
[GitHub] [yunikorn-core] wusamzong opened a new pull request, #457: [YUNIKORN-1430] change go version check in Makefile
wusamzong opened a new pull request, #457:
URL: https://github.com/apache/yunikorn-core/pull/457
### What is this PR for?
Point `MOD_VERSION` to `.go_version`, which will cause the make to fail if go is too old
I am going to update to all repos
### What type of PR is it?
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1430
### How should this be tested?
`make`
### Screenshots (if appropriate)
Here is the result I use go1.16
Here is the result I use go1.18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wusamzong commented on pull request #457: [YUNIKORN-1430] change go version check in Makefile
Posted by GitBox <gi...@apache.org>.
wusamzong commented on PR #457:
URL: https://github.com/apache/yunikorn-core/pull/457#issuecomment-1331830777
> Need to move the go setup task prior to the license check task.
Do you mean that if an error occurs during the `go build` phase, `Build should be run with at least go $(MOD_VERSION) or later, found $(GO_VERSION)` will be displayed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wusamzong commented on pull request #457: [YUNIKORN-1430] change go version check in Makefile
Posted by GitBox <gi...@apache.org>.
wusamzong commented on PR #457:
URL: https://github.com/apache/yunikorn-core/pull/457#issuecomment-1331712321
> Need to move the go setup task prior to the license check task.
I’m not sure I understand what you mean.
If it should be changed to the following?
```
.PHONY: run
run: license-check build
@echo "running scheduler locally"
...
.PHONY: run_plugin
run_plugin: license-check build_plugin
@echo "running scheduler plugin locally"
...
```
Put the `license-check` phase before the `build` phase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #457: [YUNIKORN-1430] change go version check in Makefile
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #457: [YUNIKORN-1430] change go version check in Makefile
URL: https://github.com/apache/yunikorn-core/pull/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on pull request #457: [YUNIKORN-1430] change go version check in Makefile
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #457:
URL: https://github.com/apache/yunikorn-core/pull/457#issuecomment-1332126304
> Do you mean that if an error occurs during the `go build` phase, `Build should be run with at least go $(MOD_VERSION) or later, found $(GO_VERSION)` will be displayed?
No, the build fails because the license check GitHub action comes before the step which installs the correct version of go. You need to update the GitHub workflow file to reverse this order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wusamzong commented on pull request #457: [YUNIKORN-1430] change go version check in Makefile
Posted by GitBox <gi...@apache.org>.
wusamzong commented on PR #457:
URL: https://github.com/apache/yunikorn-core/pull/457#issuecomment-1333066733
> No, the build fails because the license check GitHub action comes before the step which installs the correct version of go. You need to update the GitHub workflow file to reverse this order.
Ok, I push a new commit on all repos, and all checked passed on k8shim.
While the workflow on core, scheduler-interface is awaiting approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org