[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #336: GUACAMOLE-1283: Add synchronization around absolutely all outbound RDP messages.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #336:
URL: https://github.com/apache/guacamole-server/pull/336#discussion_r611095698



##########
File path: src/protocols/rdp/channels/audio-input/audio-buffer.h
##########
@@ -40,8 +51,8 @@
  *     The arbitrary data pointer provided when the audio buffer was
  *     initialized.
  */
-typedef void guac_rdp_audio_buffer_flush_handler(char* buffer, int length,
-        void* data);
+typedef void guac_rdp_audio_buffer_flush_handler(guac_rdp_audio_buffer* audio_buffer,
+        char* buffer, int length, void* data);

Review comment:
       We could, sure. The same could go for `data`, which is also part of `guac_rdp_audio_buffer`. Would you prefer something like:
   
   ```c
   typedef void guac_rdp_audio_buffer_flush_handler(guac_rdp_audio_buffer* audio_buffer, int length);
   ```
   
   ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org