You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Guenter Knauf <fu...@apache.org> on 2013/05/27 08:34:56 UTC

Re: svn commit: r1482918 - in /httpd/httpd/trunk: modules/http/http_filters.c server/protocol.c

Hi Graham,
seems you forgot to add a log number at line 1541:

On 15.05.2013 17:46, minfrin@apache.org wrote:
> Author: minfrin
> Date: Wed May 15 15:46:01 2013
> New Revision: 1482918
>
> URL: http://svn.apache.org/r1482918
> Log:
> core: Stop ap_finalize_request_protocol() and ap_get_client_block() from silently
> swallowing errors from the filter stack, create error buckets and return them
> appropriately.
>
> Modified:
>      httpd/httpd/trunk/modules/http/http_filters.c
>      httpd/httpd/trunk/server/protocol.c
>
> Modified: httpd/httpd/trunk/modules/http/http_filters.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=1482918&r1=1482917&r2=1482918&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http/http_filters.c (original)
> +++ httpd/httpd/trunk/modules/http/http_filters.c Wed May 15 15:46:01 2013
...
> +        if (APR_SUCCESS != rv) {
> +            ap_log_rerror(APLOG_MARK, APLOG_INFO, rv, r, APLOGNO()
> +                          "Error while writing error response");
> +        }
> +
>           /* if we actually fail here, we want to just return and
>            * stop trying to read data from the client.
>            */
>

Gün.