You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mfuxi (via GitHub)" <gi...@apache.org> on 2023/04/29 09:04:36 UTC

[GitHub] [pulsar-helm-chart] mfuxi opened a new pull request, #360: add ingressClassName

mfuxi opened a new pull request, #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360

   Fixes #333 
   ### Motivation
   
   We should be able to add ingressClassName to any of the ingress rules (pulsar-proxy,pulsar_manager and dashboard) and putting in the annotation as `kubernetes.io/ingress.class` was deprecated long time ago
   
   ### Modifications
   
   I Added in: proxy-ingress, dashboard-ingress and pulsar-manager-ingress templates the support for `ingressClassName` together with adding `ingressClassName: ""` under each context in `values.yaml` 
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #360: add ingressClassName

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on code in PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#discussion_r1184536254


##########
charts/pulsar/templates/dashboard-ingress.yaml:
##########
@@ -36,6 +36,9 @@ metadata:
   name: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
   namespace: {{ template "pulsar.namespace" . }}
 spec:
+  {{- with .Values.dashboard.ingress.ingressClassName }}

Review Comment:
   I haven't used [with](https://helm.sh/docs/chart_template_guide/control_structures/#modifying-scope-using-with) before. That is very handy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari merged pull request #360: add ingressClassName

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #360: add ingressClassName

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1535687157

   I agree. I looked into it a bit tonight but wasn't able to figure it out. I'll keep looking into it. I am hoping we can do another release soon with the just released pulsar 3.0.0 docker image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari closed pull request #360: add ingressClassName

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #360: add ingressClassName
URL: https://github.com/apache/pulsar-helm-chart/pull/360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] juangimenezrp commented on pull request #360: add ingressClassName

Posted by "juangimenezrp (via GitHub)" <gi...@apache.org>.
juangimenezrp commented on PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1574301483

   Hi, Any new with this feature?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #360: add ingressClassName

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1629651378

   Closing and re-opening to trigger a new CI run with recent CI fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #360: add ingressClassName

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1534099041

   We'll need to figure out why CI is failing before we can merge this. The issue seems unrelated to this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] mfuxi commented on pull request #360: add ingressClassName

Posted by "mfuxi (via GitHub)" <gi...@apache.org>.
mfuxi commented on PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1534126328

   Seems like a connectivity issue with the kind cluster


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org