You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/04/20 03:39:38 UTC
Re: [PR] [AURON #2208] correctness testing: setup correctness testing scaffolding for all spark versions [auron]
Copilot commented on code in PR #2209:
URL: https://github.com/apache/auron/pull/2209#discussion_r3108116072
##########
auron-spark-tests/spark35/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.auron.utils
+
+class AuronSparkTestSettings extends SparkTestSettings {
+ override def getSQLQueryTestSettings: SQLQueryTestSettings = new SQLQueryTestSettings {
+ override def getResourceFilePath: String = ""
+ override def getSupportedSQLQueryTests: Set[String] = Set.empty
+ override def getOverwriteSQLQueryTests: Set[String] = Set.empty
Review Comment:
`SparkTestSettings.shouldRun` returns false unless the suite is registered via `enableSuite(...)`. Since this settings stub never enables any suites, all tests that extend `SparkTestsBase` will be marked as ignored for Spark 3.5, so this module won’t actually execute the shared correctness suite. If the goal is to run any tests under this profile, add the appropriate `enableSuite` registrations (even a minimal set). If the goal is a placeholder only, consider making that explicit (e.g., disable suites with a reason) to avoid CI giving a false impression of test coverage.
##########
auron-spark-tests/spark34/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.auron.utils
+
+class AuronSparkTestSettings extends SparkTestSettings {
+ override def getSQLQueryTestSettings: SQLQueryTestSettings = new SQLQueryTestSettings {
+ override def getResourceFilePath: String = ""
+ override def getSupportedSQLQueryTests: Set[String] = Set.empty
+ override def getOverwriteSQLQueryTests: Set[String] = Set.empty
Review Comment:
`SparkTestSettings.shouldRun` returns false unless the suite is registered via `enableSuite(...)`. Since this settings stub never enables any suites, all tests that extend `SparkTestsBase` will be marked as ignored for Spark 3.4, so this module won’t actually execute the shared correctness suite. If the goal is to run any tests under this profile, add the appropriate `enableSuite` registrations (even a minimal set). If the goal is a placeholder only, consider making that explicit (e.g., disable suites with a reason) to avoid CI giving a false impression of test coverage.
##########
auron-spark-tests/spark31/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.auron.utils
+
+class AuronSparkTestSettings extends SparkTestSettings {
+ override def getSQLQueryTestSettings: SQLQueryTestSettings = new SQLQueryTestSettings {
+ override def getResourceFilePath: String = ""
+ override def getSupportedSQLQueryTests: Set[String] = Set.empty
+ override def getOverwriteSQLQueryTests: Set[String] = Set.empty
Review Comment:
`SparkTestSettings.shouldRun` returns false unless the suite is registered via `enableSuite(...)`. Since this settings stub never enables any suites, all tests that extend `SparkTestsBase` will be marked as ignored for Spark 3.1, so this module won’t actually execute the shared correctness suite. If the goal is to run any tests under this profile, add the appropriate `enableSuite` registrations (even a minimal set). If the goal is a placeholder only, consider making that explicit (e.g., disable suites with a reason) to avoid CI giving a false impression of test coverage.
##########
auron-spark-tests/spark40/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.auron.utils
+
+class AuronSparkTestSettings extends SparkTestSettings {
+ override def getSQLQueryTestSettings: SQLQueryTestSettings = new SQLQueryTestSettings {
+ override def getResourceFilePath: String = ""
+ override def getSupportedSQLQueryTests: Set[String] = Set.empty
+ override def getOverwriteSQLQueryTests: Set[String] = Set.empty
Review Comment:
`SparkTestSettings.shouldRun` returns false unless the suite is registered via `enableSuite(...)`. Since this settings stub never enables any suites, all tests that extend `SparkTestsBase` will be marked as ignored for Spark 4.0, so this module won’t actually execute the shared correctness suite. If the goal is to run any tests under this profile, add the appropriate `enableSuite` registrations (even a minimal set). If the goal is a placeholder only, consider making that explicit (e.g., disable suites with a reason) to avoid CI giving a false impression of test coverage.
##########
auron-spark-tests/spark41/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.auron.utils
+
+class AuronSparkTestSettings extends SparkTestSettings {
+ override def getSQLQueryTestSettings: SQLQueryTestSettings = new SQLQueryTestSettings {
+ override def getResourceFilePath: String = ""
+ override def getSupportedSQLQueryTests: Set[String] = Set.empty
+ override def getOverwriteSQLQueryTests: Set[String] = Set.empty
Review Comment:
`SparkTestSettings.shouldRun` returns false unless the suite is registered via `enableSuite(...)`. Since this settings stub never enables any suites, all tests that extend `SparkTestsBase` will be marked as ignored for Spark 4.1, so this module won’t actually execute the shared correctness suite. If the goal is to run any tests under this profile, add the appropriate `enableSuite` registrations (even a minimal set). If the goal is a placeholder only, consider making that explicit (e.g., disable suites with a reason) to avoid CI giving a false impression of test coverage.
##########
auron-spark-tests/spark32/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.auron.utils
+
+class AuronSparkTestSettings extends SparkTestSettings {
+ override def getSQLQueryTestSettings: SQLQueryTestSettings = new SQLQueryTestSettings {
+ override def getResourceFilePath: String = ""
+ override def getSupportedSQLQueryTests: Set[String] = Set.empty
+ override def getOverwriteSQLQueryTests: Set[String] = Set.empty
Review Comment:
`SparkTestSettings.shouldRun` returns false unless the suite is registered via `enableSuite(...)`. Since this settings stub never enables any suites, all tests that extend `SparkTestsBase` will be marked as ignored for Spark 3.2, so this module won’t actually execute the shared correctness suite. If the goal is to run any tests under this profile, add the appropriate `enableSuite` registrations (even a minimal set). If the goal is a placeholder only, consider making that explicit (e.g., disable suites with a reason) to avoid CI giving a false impression of test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org