You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/12/13 23:03:40 UTC

[GitHub] athanatos commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

athanatos commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.
URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-447153185
 
 
   I don't really get why isEnsembleFellbackToRandom needs to work like that.  Can't we just propagate that information from where the fallback actually happens?
   
   Also, probably better create an object with named fields rather than using a Pair.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services