You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jameslamb <gi...@git.apache.org> on 2018/11/01 14:30:28 UTC
[GitHub] spark pull request #22922: [SPARK-25909] fix documentation on cluster manage...
GitHub user jameslamb opened a pull request:
https://github.com/apache/spark/pull/22922
[SPARK-25909] fix documentation on cluster managers
## What changes were proposed in this pull request?
Propose changing the documentation to state that there are 4, not 3, cluster managers available.
## How was this patch tested?
This is a docs-only patch and doesn't need any new testing beyond the normal CI process for Spark.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jameslamb/spark bugfix/cluster_docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22922
----
commit 313d1c112b0c70a5daccce7f3cf900be6d77e944
Author: James Lamb <ja...@...>
Date: 2018-11-01T14:29:15Z
[SPARK-25909] fix documentation on cluster managers
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22922: [SPARK-25909] fix documentation on cluster managers
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22922
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22922: [SPARK-25909] fix documentation on cluster managers
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22922
Merged to master/2.4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22922: [SPARK-25909] fix documentation on cluster manage...
Posted by jameslamb <gi...@git.apache.org>.
Github user jameslamb commented on a diff in the pull request:
https://github.com/apache/spark/pull/22922#discussion_r230163184
--- Diff: docs/cluster-overview.md ---
@@ -45,7 +45,7 @@ There are several useful things to note about this architecture:
# Cluster Manager Types
-The system currently supports three cluster managers:
+The system currently supports four cluster managers:
--- End diff --
ha good idea, I'll do that.
Nope everything else was great!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22922: [SPARK-25909] fix documentation on cluster managers
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22922
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22922: [SPARK-25909] fix documentation on cluster manage...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22922#discussion_r230159527
--- Diff: docs/cluster-overview.md ---
@@ -45,7 +45,7 @@ There are several useful things to note about this architecture:
# Cluster Manager Types
-The system currently supports three cluster managers:
+The system currently supports four cluster managers:
--- End diff --
Heh OK. Let's just say 'several' to reduce future maintenance. Anything else that can be fixed in this doc?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22922: [SPARK-25909] fix documentation on cluster manage...
Posted by jameslamb <gi...@git.apache.org>.
Github user jameslamb commented on a diff in the pull request:
https://github.com/apache/spark/pull/22922#discussion_r230163716
--- Diff: docs/cluster-overview.md ---
@@ -45,7 +45,7 @@ There are several useful things to note about this architecture:
# Cluster Manager Types
-The system currently supports three cluster managers:
+The system currently supports four cluster managers:
--- End diff --
fixed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22922: [SPARK-25909] fix documentation on cluster manage...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22922
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22922: [SPARK-25909] fix documentation on cluster managers
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22922
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org