[GitHub] [spark] cloud-fan commented on a diff in pull request #38604: [SPARK-41102][CONNECT][REFACTORING] Merge SparkConnectPlanner and SparkConnectCommandPlanner

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38604:
URL: https://github.com/apache/spark/pull/38604#discussion_r1019793647


##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -39,14 +46,17 @@ final case class InvalidPlanInput(
     private val cause: Throwable = None.orNull)
     extends Exception(message, cause)
 
-class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
+final case class InvalidCommandInput(

Review Comment:
   Not related to this PR, but today we prefer to use error classes to differentiate different errors, instead of using different java exception classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org