You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/21 11:40:43 UTC
[GitHub] [flink] AHeise opened a new pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
AHeise opened a new pull request #17536:
URL: https://github.com/apache/flink/pull/17536
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR refactors `SinkOperator` setup and ensures that `GlobalCommitter` does not use `notifyCheckpointComplete` anymore since it may actually invoked before all `Committers` are notified. Thus, the global committer receives an incomplete set of `Committables` which will cause incorrect results in a final checkpoint setting.
## Brief change log
- Refactor `SinkOperator` and `CommitterOperator` setup such that the actual distribution logic resides in `SinkTransformationTranslator`.
- Change parallelism of `Committer` to p and ensure a blocking pipeline in batch mode.
- Trigger `GlobalCommitter` when all downstream `Committers` emitted the committables.
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fbfa27d34f86479d352240fe8a16c07f338aedb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
}, {
"hash" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594",
"triggerID" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"triggerType" : "PUSH"
}, {
"hash" : "b9629cad521194d28cc6fd37d2997b8589af991e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b9629cad521194d28cc6fd37d2997b8589af991e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b497327e8abc9e96acf416776bb5c9a332f950c2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594)
* b9629cad521194d28cc6fd37d2997b8589af991e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948530559
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a629d699fab399bd0f71f90f81ec873c5eb370ad (Thu Oct 21 11:45:31 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17536:
URL: https://github.com/apache/flink/pull/17536#discussion_r735868485
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitRetrier.java
##########
@@ -21,33 +21,44 @@
import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
import org.apache.flink.util.clock.Clock;
import org.apache.flink.util.clock.SystemClock;
+import org.apache.flink.util.function.ThrowingConsumer;
import java.io.IOException;
+import java.util.Collection;
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
* Retries the committables of a {@link CommitterHandler} until all committables are eventually
* committed.
*/
-class CommitRetrier {
+class CommitRetrier<CommT> {
+ @VisibleForTesting static final int RETRY_DELAY = 1000;
private final ProcessingTimeService processingTimeService;
- private final CommitterHandler<?> committerHandler;
+ private final CommitterHandler<CommT> committerHandler;
+ private final ThrowingConsumer<? super Collection<CommT>, IOException> committableConsumer;
private final Clock clock;
- @VisibleForTesting static final int RETRY_DELAY = 1000;
public CommitRetrier(
- ProcessingTimeService processingTimeService, CommitterHandler<?> committerHandler) {
- this(processingTimeService, committerHandler, SystemClock.getInstance());
+ ProcessingTimeService processingTimeService,
+ CommitterHandler<CommT> committerHandler,
+ ThrowingConsumer<? super Collection<CommT>, IOException> committableConsumer) {
Review comment:
I used a lambda here as a callback for timer-based retry. Not sure how this can be solved differently.
I certainly would try to avoid having the retrier in the emitCommittables - that can probably lead to nasty stack exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
}, {
"hash" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594",
"triggerID" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b497327e8abc9e96acf416776bb5c9a332f950c2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17536:
URL: https://github.com/apache/flink/pull/17536#discussion_r735371614
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/ForwardCommittingHandler.java
##########
@@ -17,15 +17,19 @@
package org.apache.flink.streaming.runtime.operators.sink;
+import org.apache.flink.api.connector.sink.Committer;
+
import java.io.IOException;
import java.util.List;
/**
* This committer handler simply forwards all committables downstream. It's used in {@link
* SinkOperator} without committers but with downstream operators (in streaming, only global
* committer on sink; in batch, committer or global committer present).
+ *
+ * @param <CommT> The input and output type of the {@link Committer}.
*/
-class ForwardCommittingHandler<CommT> extends AbstractCommitterHandler<CommT, CommT, CommT> {
+class ForwardCommittingHandler<CommT> extends AbstractCommitterHandler<CommT, Void> {
Review comment:
I am not sure whether the abstraction of `ForwardingCommittingHandler` and `NoopCommittingHandler` really makes sense anymore after the refactoring. In the end, it could be a simple boolean flag whether the committables should be sent downstream if there is a global committer.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/AbstractCommitterHandler.java
##########
@@ -65,21 +68,55 @@ protected void recoveredCommittables(List<StateT> recovered) throws IOException
return all;
}
+ protected final Collection<StateT> commitAndReturnSuccess(List<StateT> committables)
+ throws IOException, InterruptedException {
+ Collection<StateT> failed = commit(committables);
+ if (failed.isEmpty()) {
+ return committables;
+ }
+ // Assume that (Global)Committer#commit does not create a new instance for failed
+ // committables. This assumption is documented in the respective JavaDoc.
+ Set<StateT> successful =
+ Collections.newSetFromMap(new IdentityHashMap<>(committables.size()));
+ successful.addAll(committables);
+ successful.removeAll(failed);
+ return successful;
+ }
+
+ protected final Collection<StateT> commit(List<StateT> committables)
+ throws IOException, InterruptedException {
+ List<StateT> failed = commitInternal(committables);
+ recoveredCommittables(failed);
+ return failed;
+ }
+
+ /**
+ * Commits a list of committables.
+ *
+ * @param committables A list of committables that is ready for committing.
+ * @return A list of committables needed to re-commit.
+ */
+ abstract List<StateT> commitInternal(List<StateT> committables)
+ throws IOException, InterruptedException;
+
@Override
public boolean needsRetry() {
return !recoveredCommittables.isEmpty();
}
@Override
- public void retry() throws IOException, InterruptedException {
- retry(prependRecoveredCommittables(Collections.emptyList()));
+ public Collection<CommT> retry() throws IOException, InterruptedException {
+ return retry(prependRecoveredCommittables(Collections.emptyList()));
}
- protected abstract void retry(List<StateT> recoveredCommittables)
- throws IOException, InterruptedException;
+ protected Collection<CommT> retry(List<StateT> recoveredCommittables)
Review comment:
AFAICT `StreamingCommitterHandler` and `BatchCommitterHandler` override this method but have identical implementations
```java
@Override
protected Collection<CommT> retry(List<CommT> recoveredCommittables)
throws IOException, InterruptedException {
return commitAndReturnSuccess(recoveredCommittables);
}
```
Why can't we move the implementation to this class in the `retry` method?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java
##########
@@ -51,6 +53,7 @@
Object, SinkTransformation<InputT, CommT, WriterStateT, GlobalCommT>> {
protected static final Logger LOG = LoggerFactory.getLogger(SinkTransformationTranslator.class);
+ public static final TypeInformation<byte[]> BYTES = TypeInformation.of(byte[].class);
Review comment:
private?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitRetrier.java
##########
@@ -21,33 +21,44 @@
import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
import org.apache.flink.util.clock.Clock;
import org.apache.flink.util.clock.SystemClock;
+import org.apache.flink.util.function.ThrowingConsumer;
import java.io.IOException;
+import java.util.Collection;
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
* Retries the committables of a {@link CommitterHandler} until all committables are eventually
* committed.
*/
-class CommitRetrier {
+class CommitRetrier<CommT> {
+ @VisibleForTesting static final int RETRY_DELAY = 1000;
private final ProcessingTimeService processingTimeService;
- private final CommitterHandler<?> committerHandler;
+ private final CommitterHandler<CommT> committerHandler;
+ private final ThrowingConsumer<? super Collection<CommT>, IOException> committableConsumer;
private final Clock clock;
- @VisibleForTesting static final int RETRY_DELAY = 1000;
public CommitRetrier(
- ProcessingTimeService processingTimeService, CommitterHandler<?> committerHandler) {
- this(processingTimeService, committerHandler, SystemClock.getInstance());
+ ProcessingTimeService processingTimeService,
+ CommitterHandler<CommT> committerHandler,
+ ThrowingConsumer<? super Collection<CommT>, IOException> committableConsumer) {
Review comment:
I don't like passing a lambda here because it is only used for emitting. I think we can simplify it by only passing a boolean to determine if emitting is necessary.
Also currently the `CommitterOperator#emitCommittables` references the `commiterRetrier` I think this may lead to weird situations.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterHandler.java
##########
@@ -72,4 +78,32 @@ default void snapshotState(StateSnapshotContext context) throws Exception {}
* @return successfully retried committables that is sent downstream.
*/
Collection<CommT> retry() throws IOException, InterruptedException;
+
+ /**
+ * The serializable factory of a committer handler such that the stateful implementations of
+ * {@link CommitterHandler} do not need to be {@link Serializable} themselves.
+ */
+ interface Factory<Sink, CommT> extends Serializable {
+ CommitterHandler<CommT> create(Sink sink) throws IOException;
+
+ default <T> T checkSerializerPresent(Optional<T> optional, boolean global) {
+ String scope = global ? " global" : "";
+ checkState(
+ optional.isPresent(),
+ "Internal error: a%s committer should only be created if the sink has a%s committable serializer.",
+ scope,
+ scope);
+ return optional.get();
+ }
+
+ default <T> T checkCommitterPresent(Optional<T> optional, boolean global) {
+ String scope = global ? " global" : "";
+ checkState(
+ optional.isPresent(),
+ "Expected a%s committer because%s committable serializer is set.",
+ scope,
+ scope);
+ return optional.get();
+ }
+ }
Review comment:
Not sure I really like this approach of sharing utility functions but having them in separate class probably does not change much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf7c715552579498eeaf5733797182563f2ba625 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fbfa27d34f86479d352240fe8a16c07f338aedb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343)
* cf7c715552579498eeaf5733797182563f2ba625 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
}, {
"hash" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf7c715552579498eeaf5733797182563f2ba625 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545)
* b497327e8abc9e96acf416776bb5c9a332f950c2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
}, {
"hash" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594",
"triggerID" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"triggerType" : "PUSH"
}, {
"hash" : "b9629cad521194d28cc6fd37d2997b8589af991e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25862",
"triggerID" : "b9629cad521194d28cc6fd37d2997b8589af991e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b9629cad521194d28cc6fd37d2997b8589af991e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25862)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #17536:
URL: https://github.com/apache/flink/pull/17536#discussion_r737251376
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterHandler.java
##########
@@ -72,4 +78,32 @@ default void snapshotState(StateSnapshotContext context) throws Exception {}
* @return successfully retried committables that is sent downstream.
*/
Collection<CommT> retry() throws IOException, InterruptedException;
+
+ /**
+ * The serializable factory of a committer handler such that the stateful implementations of
+ * {@link CommitterHandler} do not need to be {@link Serializable} themselves.
+ */
+ interface Factory<Sink, CommT> extends Serializable {
+ CommitterHandler<CommT> create(Sink sink) throws IOException;
+
+ default <T> T checkSerializerPresent(Optional<T> optional, boolean global) {
+ String scope = global ? " global" : "";
+ checkState(
+ optional.isPresent(),
+ "Internal error: a%s committer should only be created if the sink has a%s committable serializer.",
+ scope,
+ scope);
+ return optional.get();
+ }
+
+ default <T> T checkCommitterPresent(Optional<T> optional, boolean global) {
+ String scope = global ? " global" : "";
+ checkState(
+ optional.isPresent(),
+ "Expected a%s committer because%s committable serializer is set.",
+ scope,
+ scope);
+ return optional.get();
+ }
+ }
Review comment:
The abstract class sounds better then the scope is also more limited and the methods are not exposed to external calleers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17536:
URL: https://github.com/apache/flink/pull/17536#discussion_r735867252
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/AbstractCommitterHandler.java
##########
@@ -65,21 +68,55 @@ protected void recoveredCommittables(List<StateT> recovered) throws IOException
return all;
}
+ protected final Collection<StateT> commitAndReturnSuccess(List<StateT> committables)
+ throws IOException, InterruptedException {
+ Collection<StateT> failed = commit(committables);
+ if (failed.isEmpty()) {
+ return committables;
+ }
+ // Assume that (Global)Committer#commit does not create a new instance for failed
+ // committables. This assumption is documented in the respective JavaDoc.
+ Set<StateT> successful =
+ Collections.newSetFromMap(new IdentityHashMap<>(committables.size()));
+ successful.addAll(committables);
+ successful.removeAll(failed);
+ return successful;
+ }
+
+ protected final Collection<StateT> commit(List<StateT> committables)
+ throws IOException, InterruptedException {
+ List<StateT> failed = commitInternal(committables);
+ recoveredCommittables(failed);
+ return failed;
+ }
+
+ /**
+ * Commits a list of committables.
+ *
+ * @param committables A list of committables that is ready for committing.
+ * @return A list of committables needed to re-commit.
+ */
+ abstract List<StateT> commitInternal(List<StateT> committables)
+ throws IOException, InterruptedException;
+
@Override
public boolean needsRetry() {
return !recoveredCommittables.isEmpty();
}
@Override
- public void retry() throws IOException, InterruptedException {
- retry(prependRecoveredCommittables(Collections.emptyList()));
+ public Collection<CommT> retry() throws IOException, InterruptedException {
+ return retry(prependRecoveredCommittables(Collections.emptyList()));
}
- protected abstract void retry(List<StateT> recoveredCommittables)
- throws IOException, InterruptedException;
+ protected Collection<CommT> retry(List<StateT> recoveredCommittables)
Review comment:
That's unfortunately not that easy because of the global committers: Currently all committers are emitting `CommT` and not `GlobalCommT` anymore after this refactor. This is possible because in fact the global committers are not emitting anything.
Now `commitAndReturnSuccess` is working on the internal type (`GlobalCommT` in case of global committers). Hence, the signature is conflicting here.
We could create mix-ins interfaces for non-global and global committers where we can implement them. The question is if that's simpler. We could also re-introduce an emit type to `CommitterHandler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17536:
URL: https://github.com/apache/flink/pull/17536#discussion_r735863018
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/ForwardCommittingHandler.java
##########
@@ -17,15 +17,19 @@
package org.apache.flink.streaming.runtime.operators.sink;
+import org.apache.flink.api.connector.sink.Committer;
+
import java.io.IOException;
import java.util.List;
/**
* This committer handler simply forwards all committables downstream. It's used in {@link
* SinkOperator} without committers but with downstream operators (in streaming, only global
* committer on sink; in batch, committer or global committer present).
+ *
+ * @param <CommT> The input and output type of the {@link Committer}.
*/
-class ForwardCommittingHandler<CommT> extends AbstractCommitterHandler<CommT, CommT, CommT> {
+class ForwardCommittingHandler<CommT> extends AbstractCommitterHandler<CommT, Void> {
Review comment:
They are still needed in the current `SinkOperator`:
- In batch with committer, we need `ForwardingCommittingHandler`.
- In stream/batch without any committer, we need `NoopCommittingHandler`.
We could replace them by booleans but it's getting a bit ugly:
- In streaming, we only emit on `notifyCheckpointCompleted`.
- In batch, we only emit on `preSnapshotBarrier`.
So you'd need two booleans afaik. It's certainly less code but I'm not sure if it's easier to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
}, {
"hash" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594",
"triggerID" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf7c715552579498eeaf5733797182563f2ba625 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545)
* b497327e8abc9e96acf416776bb5c9a332f950c2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25545",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
}, {
"hash" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594",
"triggerID" : "b497327e8abc9e96acf416776bb5c9a332f950c2",
"triggerType" : "PUSH"
}, {
"hash" : "b9629cad521194d28cc6fd37d2997b8589af991e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25862",
"triggerID" : "b9629cad521194d28cc6fd37d2997b8589af991e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b497327e8abc9e96acf416776bb5c9a332f950c2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25594)
* b9629cad521194d28cc6fd37d2997b8589af991e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25862)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
}, {
"hash" : "cf7c715552579498eeaf5733797182563f2ba625",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cf7c715552579498eeaf5733797182563f2ba625",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fbfa27d34f86479d352240fe8a16c07f338aedb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25343)
* cf7c715552579498eeaf5733797182563f2ba625 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
}, {
"hash" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338",
"triggerID" : "768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd",
"triggerType" : "PUSH"
}, {
"hash" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fbfa27d34f86479d352240fe8a16c07f338aedb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
* 768cf63bd307aecdb3b0c3ddc9d2ccdc966cabcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25338)
* 4fbfa27d34f86479d352240fe8a16c07f338aedb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17536:
URL: https://github.com/apache/flink/pull/17536#issuecomment-948529514
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318",
"triggerID" : "a629d699fab399bd0f71f90f81ec873c5eb370ad",
"triggerType" : "PUSH"
}, {
"hash" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331",
"triggerID" : "79b2bd332c3ea649be3cf9dc4310223ce34cc925",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a629d699fab399bd0f71f90f81ec873c5eb370ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25318)
* 79b2bd332c3ea649be3cf9dc4310223ce34cc925 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17536: [FLINK-24530][datastream] GlobalCommitter might not commit all records on drain
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17536:
URL: https://github.com/apache/flink/pull/17536#discussion_r735869185
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterHandler.java
##########
@@ -72,4 +78,32 @@ default void snapshotState(StateSnapshotContext context) throws Exception {}
* @return successfully retried committables that is sent downstream.
*/
Collection<CommT> retry() throws IOException, InterruptedException;
+
+ /**
+ * The serializable factory of a committer handler such that the stateful implementations of
+ * {@link CommitterHandler} do not need to be {@link Serializable} themselves.
+ */
+ interface Factory<Sink, CommT> extends Serializable {
+ CommitterHandler<CommT> create(Sink sink) throws IOException;
+
+ default <T> T checkSerializerPresent(Optional<T> optional, boolean global) {
+ String scope = global ? " global" : "";
+ checkState(
+ optional.isPresent(),
+ "Internal error: a%s committer should only be created if the sink has a%s committable serializer.",
+ scope,
+ scope);
+ return optional.get();
+ }
+
+ default <T> T checkCommitterPresent(Optional<T> optional, boolean global) {
+ String scope = global ? " global" : "";
+ checkState(
+ optional.isPresent(),
+ "Expected a%s committer because%s committable serializer is set.",
+ scope,
+ scope);
+ return optional.get();
+ }
+ }
Review comment:
How about I change the Factory interface to an abstract class? It might be weird because they are default methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org