You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2024/03/05 08:19:14 UTC
[PR] fix: coalesce function should return correct data type [arrow-datafusion]
viirya opened a new pull request, #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #9458.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: coalesce function should return correct data type [arrow-datafusion]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya merged PR #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: coalesce function should return correct data type [arrow-datafusion]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459#discussion_r1513598236
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -408,8 +412,19 @@ fn coerced_from<'a>(
Some(type_into.clone())
}
- // cannot coerce
- _ => None,
+ // More coerce rules.
+ // Note that not all rules in `comparison_coercion` can be reused here.
+ // For example, all numeric types can be coerced into Utf8 for comparison,
+ // but not for function arguments.
+ _ => comparison_binary_numeric_coercion(type_into, type_from).and_then(
+ |coerced_type| {
+ if *type_into == coerced_type {
+ Some(coerced_type)
+ } else {
Review Comment:
For function argument, we want to coerce to exact the type (valid type) instead of third type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: coalesce function should return correct data type [arrow-datafusion]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459#issuecomment-1979321810
Some remaining test failures are unrelated. But some seem related. I'll keep looking into them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: coalesce function should return correct data type [arrow-datafusion]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459#discussion_r1513598827
##########
datafusion/physical-expr/src/math_expressions.rs:
##########
@@ -92,8 +93,9 @@ macro_rules! downcast_arg {
($ARG:expr, $NAME:expr, $ARRAY_TYPE:ident) => {{
$ARG.as_any().downcast_ref::<$ARRAY_TYPE>().ok_or_else(|| {
DataFusionError::Internal(format!(
- "could not cast {} to {}",
+ "could not cast {} from {} to {}",
$NAME,
+ $ARG.data_type(),
type_name::<$ARRAY_TYPE>()
))
Review Comment:
When I debug, I found that it is a more useful error message to show the source data type too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: coalesce function should return correct data type [arrow-datafusion]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #9459:
URL: https://github.com/apache/arrow-datafusion/pull/9459#issuecomment-1983841929
Thanks @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org