[jira] Commented: (SHINDIG-259) Improve logging calls

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596392#action_12596392 ] 

Henning Schmiedehausen commented on SHINDIG-259:
------------------------------------------------

As shindig is intended to be embedded, I very much agree that logging flexibility is wanted. I don't feel that any logging library is a good choice; I'd actually recommend that we move to a logging injection pattern which leaves us log agnostic. 

public interface ShindigLogging {
    void debug(String msg, ...);

    void notice(String msg, ...);

    void warn(String msg, ...);

    void error(String msg, ...);

    void fail(String msg, ...);
}

Add a factory that hands out instances for this and a Guice injector that binds the concrete client implementation to this interface and you should be good to go. We add a default implementation that uses jdk logging.

> Improve logging calls
> ---------------------
>
>                 Key: SHINDIG-259
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-259
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
>            Reporter: Vincent Siveton
>            Priority: Minor
>
> Just for the track, see thread on shindig-dev@
> http://markmail.org/message/6ihyisqsrqp4nnt5

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.