You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Marta Kuczora via Review Board <no...@reviews.apache.org> on 2018/01/29 12:27:11 UTC
Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/
-----------------------------------------------------------
Review request for hive, Peter Vary and Adam Szita.
Bugs: HIVE-18566
https://issues.apache.org/jira/browse/HIVE-18566
Repository: hive-git
Description
-------
he following methods of IMetaStoreClient are covered by this test.
- int add_partitions_pspec(PartitionSpecProxy)
The test covers not just the happy pathes, but the edge cases as well.
Diffs
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java 09be321
Diff: https://reviews.apache.org/r/65380/diff/1/
Testing
-------
Run the tests
Thanks,
Marta Kuczora
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
> On Jan. 29, 2018, 2:34 p.m., Peter Vary wrote:
> > Nice throughout test cases.
> > Thanks Marta!
> >
> > Fix it and ship it!
Thanks a lot Peter for the review.
> On Jan. 29, 2018, 2:34 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java
> > Lines 1312 (patched)
> > <https://reviews.apache.org/r/65380/diff/1/?file=1949515#file1949515line1312>
> >
> > Agree with Adam, please move it to another test class.
Moved the tests to a separate class.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/#review196431
-----------------------------------------------------------
On Jan. 30, 2018, 8:15 a.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65380/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 8:15 a.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18566
> https://issues.apache.org/jira/browse/HIVE-18566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> he following methods of IMetaStoreClient are covered by this test.
> - int add_partitions_pspec(PartitionSpecProxy)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65380/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/#review196431
-----------------------------------------------------------
Nice throughout test cases.
Thanks Marta!
Fix it and ship it!
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java
Lines 1312 (patched)
<https://reviews.apache.org/r/65380/#comment276063>
Agree with Adam, please move it to another test class.
- Peter Vary
On Jan. 29, 2018, 12:27 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65380/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:27 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18566
> https://issues.apache.org/jira/browse/HIVE-18566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> he following methods of IMetaStoreClient are covered by this test.
> - int add_partitions_pspec(PartitionSpecProxy)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java 09be321
>
>
> Diff: https://reviews.apache.org/r/65380/diff/1/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/#review196517
-----------------------------------------------------------
Ship it!
Ship It!
- Adam Szita
On Jan. 30, 2018, 8:15 a.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65380/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 8:15 a.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18566
> https://issues.apache.org/jira/browse/HIVE-18566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> he following methods of IMetaStoreClient are covered by this test.
> - int add_partitions_pspec(PartitionSpecProxy)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65380/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/#review196516
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On Jan. 30, 2018, 8:15 a.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65380/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 8:15 a.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18566
> https://issues.apache.org/jira/browse/HIVE-18566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> he following methods of IMetaStoreClient are covered by this test.
> - int add_partitions_pspec(PartitionSpecProxy)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65380/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/
-----------------------------------------------------------
(Updated Jan. 30, 2018, 8:15 a.m.)
Review request for hive, Peter Vary and Adam Szita.
Changes
-------
Addressed the review findings. Moved the tests to a different class.
Bugs: HIVE-18566
https://issues.apache.org/jira/browse/HIVE-18566
Repository: hive-git
Description
-------
he following methods of IMetaStoreClient are covered by this test.
- int add_partitions_pspec(PartitionSpecProxy)
The test covers not just the happy pathes, but the edge cases as well.
Diffs (updated)
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java PRE-CREATION
Diff: https://reviews.apache.org/r/65380/diff/2/
Changes: https://reviews.apache.org/r/65380/diff/1-2/
Testing
-------
Run the tests
Thanks,
Marta Kuczora
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
> On Jan. 29, 2018, 2:24 p.m., Adam Szita wrote:
> > Nice patch with well covered cases.
> > Since this is a lot of test code, wouldn't it make sense to move the PartitionSpec-related code into a separate class (rather than having a 2k+ LOC class)?
Thanks a lot Adam for the review.
Good point, I moved the tests to a different class.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/#review196430
-----------------------------------------------------------
On Jan. 30, 2018, 8:15 a.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65380/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 8:15 a.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18566
> https://issues.apache.org/jira/browse/HIVE-18566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> he following methods of IMetaStoreClient are covered by this test.
> - int add_partitions_pspec(PartitionSpecProxy)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65380/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65380: HIVE-18566: Create tests to cover adding
partitions from PartitionSpec
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65380/#review196430
-----------------------------------------------------------
Nice patch with well covered cases.
Since this is a lot of test code, wouldn't it make sense to move the PartitionSpec-related code into a separate class (rather than having a 2k+ LOC class)?
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java
Lines 2220-2221 (patched)
<https://reviews.apache.org/r/65380/#comment276059>
123456 may be a contant to be considered for extraction
- Adam Szita
On Jan. 29, 2018, 12:27 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65380/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:27 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18566
> https://issues.apache.org/jira/browse/HIVE-18566
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> he following methods of IMetaStoreClient are covered by this test.
> - int add_partitions_pspec(PartitionSpecProxy)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java 09be321
>
>
> Diff: https://reviews.apache.org/r/65380/diff/1/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>