You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/12 14:58:52 UTC
[GitHub] [skywalking-data-collect-protocol] arugal opened a new pull request
#14: AdduniqueId for BrowserPerfData
arugal opened a new pull request #14: AdduniqueId for BrowserPerfData
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14
ref: [skywalking#4166](https://github.com/apache/skywalking/issues/4166)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request
#14: Add uniqueId for BrowserPerfData
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #14: Add uniqueId for BrowserPerfData
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] Fine0830 commented on issue #14:
Add uniqueId for BrowserPerfData
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #14: Add uniqueId for BrowserPerfData
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14#issuecomment-573488379
UUID looks good to me. Yes, can we integrate one query for perf data and error log?
________________________________
From: 吴晟 Wu Sheng <no...@github.com>
Sent: Monday, January 13, 2020 8:43:42 AM
To: apache/skywalking-data-collect-protocol <sk...@noreply.github.com>
Cc: Qiuxia Fan <fi...@outlook.com>; Mention <me...@noreply.github.com>
Subject: Re: [apache/skywalking-data-collect-protocol] Add uniqueId for BrowserPerfData (#14)
@wu-sheng commented on this pull request.
________________________________
In browser/BrowserPerf.proto<https://github.com/apache/skywalking-data-collect-protocol/pull/14#discussion_r365624786>:
> @@ -30,17 +30,19 @@ service BrowserPerfService {
}
message BrowserPerfData {
- int32 serviceId = 1;
+ // UUID
+ string uniqueId = 1;
@Fine0830<https://github.com/Fine0830> Is it OK to generate this unique for client-js report every time? The backend will need this to save the whole report for the UI. Are we going to provide perf data and error log query from UI?
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/skywalking-data-collect-protocol/pull/14?email_source=notifications&email_token=AE7HUZ4B2WQV7E4NZRO7LEDQ5O2L5A5CNFSM4KFYCZL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCROJRYI#pullrequestreview-341612769>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE7HUZYQ27ENI2CFRAJ7ACLQ5O2L5ANCNFSM4KFYCZLQ>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #14: Add uniqueId for BrowserPerfData
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #14: Add uniqueId for BrowserPerfData
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/14#discussion_r365624786
##########
File path: browser/BrowserPerf.proto
##########
@@ -30,17 +30,19 @@ service BrowserPerfService {
}
message BrowserPerfData {
- int32 serviceId = 1;
+ // UUID
+ string uniqueId = 1;
Review comment:
@Fine0830 Is it OK to generate this unique for client-js report every time? The backend will need this to save the whole report for the UI. Are we going to provide perf data and error log query from UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services