You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/12 14:09:39 UTC
[GitHub] [airflow] kaxil opened a new pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
kaxil opened a new pull request #10898:
URL: https://github.com/apache/airflow/pull/10898
Co-authored-by: Elwin Arens <el...@gmail.com>
closes: #8258
This PR adds secrets backend for Microsoft azure key vault
This work was started at https://github.com/apache/airflow/pull/9639
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691686288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691518468
k8s failures are unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691691727
Allright I know @kaxil . It was manifestation of the #10471
Currenlty the image is built using the original commit, but the build itself is run using sources after the PR is automatically merged with master. So in the image there was no "azure-identity" and the other package added, but the sources used for pylint check already contained it (because we run static checks using the local sources).
That makes me think that I might want to try to solve it eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691686569
No, I think the test was cancelled because another PR was merged, I can't see any error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691543021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691688896
I am running my PR rebased on master now https://github.com/apache/airflow/pull/10912/checks?check_run_id=1108699419
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10898:
URL: https://github.com/apache/airflow/pull/10898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691688716
In another PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691572532
> > k8s failures are unrelated
>
> Need rebase - that was one of the previous master merges (fixed afterwards) I had the same problem with two other prs and it was fixed after rebase
rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] elwinarens commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
elwinarens commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-698744641
Thanks for the effort of picking up where i left, everyone!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691686435
Checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691688694
https://github.com/apache/airflow/runs/1108600218?check_suite_focus=true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691518468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691518468
k8s failures are unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691690782
Hmm. It works. It was an interesting race condition that I must have to take a closer look at :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-691543021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] elwinarens commented on pull request #10898: Add Secrets backend for Microsoft Azure Key Vault
Posted by GitBox <gi...@apache.org>.
elwinarens commented on pull request #10898:
URL: https://github.com/apache/airflow/pull/10898#issuecomment-698744641
Thanks for the effort of picking up where i left, everyone!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org