[GitHub] maskit commented on a change in pull request #721: Parse authParamsString on plugin side

[gi...@git.apache.org]

maskit commented on a change in pull request #721: Parse authParamsString on plugin side
URL: https://github.com/apache/incubator-pulsar/pull/721#discussion_r136197490
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Authentication.java
 ##########
 @@ -40,13 +53,46 @@
     AuthenticationDataProvider getAuthData() throws PulsarClientException;
 
     /**
-     * Configure the authentication plugins with the supplied parameters
+     * Configure the authentication plugins with the Map parameter
      *
      * @param authParams
      */
     void configure(Map<String, String> authParams);
 
     /**
+     * Configure the authentication plugins with the String parameter
+     *
+     * @param authParams
+     */
+    default void configure(String authParams) {
+        Map<String, String> authParamsMap = new HashMap<>();
+        Logger LOG = LoggerFactory.getLogger(Authentication.class);
 
 Review comment:
   Do we really want to have the two lines here? If we move parsing logic to somewhere else, we can deprecate the old interface and will have this only one universal configure interface eventually, which is more beautiful API I think.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services