[GitHub] [tvm] areusch edited a comment on pull request #8892: [Lowering] Add TargetDevice composite data structure.

[GitBox <gi...@apache.org>]

areusch edited a comment on pull request #8892:
URL: https://github.com/apache/tvm/pull/8892#issuecomment-910036578


   > On the other hand, there is direct correspondence between TargetKind to DLDeviceType, e.g. https://github.com/apache/tvm/blob/main/src/target/target_kind.cc#L278. So shall we just infer it from TargetNode::kind?
   
   @junrushao1994 how do you propose to infer the two-different-CPUs or two-different-FPGAs case? Also see my comments on the commentary at the top of target_device.cc. My thoughts are that being explicit at this level will provide a better user experience. I don't think it removes our ability to infer devices based on Target when there is no ambiguity, and it provides us a language in which we can warn the user when ambiguity exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org