Re: [PR] Improve bytebuddy class enhance for retransform classes [skywalking-java]

["wspray (via GitHub)" <gi...@apache.org>]

wspray commented on code in PR #561:
URL: https://github.com/apache/skywalking-java/pull/561#discussion_r1776997731


##########
test/plugin/scenarios/retransform-class-tomcat-scenario/configuration.yml:
##########
@@ -17,7 +17,5 @@
 type: tomcat
 entryService: http://localhost:8080/retransform-class-tomcat-scenario/case/retransform-class
 healthCheck: http://localhost:8080/retransform-class-tomcat-scenario/case/healthCheck
-environment:
-  - CATALINA_OPTS="-Dskywalking.agent.is_cache_enhanced_class=true -Dskywalking.agent.class_cache_mode=FILE"
 dependencies:
-withPlugins: apm-spring-annotation-plugin-*.jar
+withPlugins: apm-*.jar

Review Comment:
   > > I think we don't cover multiple plugins for one method case, how could that happens?
   > 
   > We now support multiple plugins enhancing the same class, although enhancing different methods, but if the same method/field name is generated, there will be an error.
   > 
   > > And even yoi copied all, it doesn't verify this, because many plugins are not activated(not used) in your scenarios.
   > 
   > Yes, and we may need more testcases.
   
   @wu-sheng @kylixs  Hello，I wonder if multiple plugins enhancing the same class has been supported?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org