You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/04 11:55:09 UTC

[GitHub] [apisix] tokers commented on a diff in pull request #6686: feat(plugin-redirect): set redirect server port when enable http_to_https

tokers commented on code in PR #6686:
URL: https://github.com/apache/apisix/pull/6686#discussion_r864744391


##########
apisix/plugins/redirect.lua:
##########
@@ -157,7 +157,7 @@ function _M.rewrite(conf, ctx)
     if conf.http_to_https and _scheme == "http" then
         -- TODO： add test case
         -- PR: https://github.com/apache/apisix/pull/1958
-        if ret_port == 443 then
+        if ret_port == 443 or ret_port == 0 then

Review Comment:
   Why check if it's equal to `0`? may be `if not ret_port or ret_port == 443`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org