You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sateesh Chodapuneedi <sa...@citrix.com> on 2013/02/05 06:41:35 UTC

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/
-----------------------------------------------------------

(Updated Feb. 5, 2013, 5:41 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Updated patch description.


Description (updated)
-------

This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.


This addresses bug CLOUDSTACK-657.


Diffs
-----

  vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 

Diff: https://reviews.apache.org/r/9196/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review17147
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On Feb. 25, 2013, 11:28 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 11:28 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 
> 
> Diff: https://reviews.apache.org/r/9196/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 11:28 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Rebased patch to latest master.


Description
-------

This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.


This addresses bug CLOUDSTACK-657.


Diffs (updated)
-----

  vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 

Diff: https://reviews.apache.org/r/9196/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi

RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Animesh Chaturvedi <an...@citrix.com>.

> -----Original Message-----
> From: rohityadav89@gmail.com [mailto:rohityadav89@gmail.com] On Behalf
> Of Rohit Yadav
> Sent: Thursday, February 21, 2013 10:15 PM
> To: cloudstack-dev@incubator.apache.org; Kelven Yang
> Cc: Murali Reddy; Sateesh Chodapuneedi
> Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch
> in CloudStack'.
> 
> It's unclear when a committer gives a ship it on reviewboard, they should also
> include information on whether it is:
> 
> - Ship it, but needs one more review
> - Ship it, and it's already merged on respective branch
> - Ship it and is not merged.
> 
> Regards.
[Animesh>] Agreed I will put this in review board guidelines
> 
> On Fri, Feb 22, 2013 at 7:49 AM, Kelven Yang <ke...@citrix.com> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9196/#review16921
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Ship It!
> >
> > - Kelven Yang
> >
> >
> > On Feb. 6, 2013, 1:19 a.m., Sateesh Chodapuneedi wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9196/
> >> -----------------------------------------------------------
> >>
> >> (Updated Feb. 6, 2013, 1:19 a.m.)
> >>
> >>
> >> Review request for cloudstack, Murali Reddy and Kelven Yang.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> >> This patch contains few helper functions (get dvswitch reference, check the
> type of a port group). Also added method getType() to VirtualSwitchType enum.
> >>
> >>
> >> This addresses bug CLOUDSTACK-657.
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
> eb10e16
> >>   vmware-
> base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
> >>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
> >> 47ff8e2
> >>
> >> Diff: https://reviews.apache.org/r/9196/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Manual testing:-
> >> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this
> case management and public traffic uses standard vSwitch on a common
> physical network.
> >> 2) Tested both guest traffic and public traffic over dvSwitch on a physical
> network.
> >> 3) Use optional parameters added to AddClusterCmd to override Zone level
> network traffic label. Tested 2 clusters, one with standard vSwitch and other
> with dvSwitch.
> >> 4) Tested all 3 traffic types on single physical network with global parameter
> 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> >>
> >>
> >> Added following tests,
> >> 1) Test fetching dvSwitch object from vCenter
> >> 2) Test for presence of dvPortGroup
> >> 3) Test presence of dvPortGroup
> >> 4) Test get existing dvPortGroup
> >> 5) fetch dvPortGroup configuration
> >> 6) Test compare dvPortGroup configuration
> >> 7) Test update dvPortGroup configuration
> >>
> >>
> >> Thanks,
> >>
> >> Sateesh Chodapuneedi
> >>
> >>
> >

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Chiradeep Vittal <Ch...@citrix.com>.

On 2/21/13 10:14 PM, "Rohit Yadav" <bh...@apache.org> wrote:

>It's unclear when a committer gives a ship it on reviewboard, they
>should also include information on whether it is:
>
>- Ship it, but needs one more review
>- Ship it, and it's already merged on respective branch
>- Ship it and is not merged.

+1000

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Rohit Yadav <bh...@apache.org>.
It's unclear when a committer gives a ship it on reviewboard, they
should also include information on whether it is:

- Ship it, but needs one more review
- Ship it, and it's already merged on respective branch
- Ship it and is not merged.

Regards.

On Fri, Feb 22, 2013 at 7:49 AM, Kelven Yang <ke...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/#review16921
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Kelven Yang
>
>
> On Feb. 6, 2013, 1:19 a.m., Sateesh Chodapuneedi wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9196/
>> -----------------------------------------------------------
>>
>> (Updated Feb. 6, 2013, 1:19 a.m.)
>>
>>
>> Review request for cloudstack, Murali Reddy and Kelven Yang.
>>
>>
>> Description
>> -------
>>
>> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
>> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
>>
>>
>> This addresses bug CLOUDSTACK-657.
>>
>>
>> Diffs
>> -----
>>
>>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16
>>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
>>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
>>
>> Diff: https://reviews.apache.org/r/9196/diff/
>>
>>
>> Testing
>> -------
>>
>> Manual testing:-
>> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
>> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
>> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
>> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>>
>>
>> Added following tests,
>> 1) Test fetching dvSwitch object from vCenter
>> 2) Test for presence of dvPortGroup
>> 3) Test presence of dvPortGroup
>> 4) Test get existing dvPortGroup
>> 5) fetch dvPortGroup configuration
>> 6) Test compare dvPortGroup configuration
>> 7) Test update dvPortGroup configuration
>>
>>
>> Thanks,
>>
>> Sateesh Chodapuneedi
>>
>>
>

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review16921
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On Feb. 6, 2013, 1:19 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 1:19 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 
> 
> Diff: https://reviews.apache.org/r/9196/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/
-----------------------------------------------------------

(Updated Feb. 6, 2013, 1:19 a.m.)


Review request for cloudstack, Murali Reddy and Kelven Yang.


Changes
-------

Updated diff after adding constant variables and removing an unused variable


Description
-------

This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.


This addresses bug CLOUDSTACK-657.


Diffs (updated)
-----

  vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 

Diff: https://reviews.apache.org/r/9196/diff/


Testing
-------

Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.


Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration


Thanks,

Sateesh Chodapuneedi

RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Animesh Chaturvedi <an...@citrix.com>.
Koushik

Please review the updated patch and commit if satisfied

> -----Original Message-----
> From: Sateesh Chodapuneedi [mailto:noreply@reviews.apache.org] On Behalf
> Of Sateesh Chodapuneedi
> Sent: Tuesday, February 05, 2013 5:19 PM
> To: Murali Reddy; Kelven Yang
> Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das
> Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch
> in CloudStack'.
> 
> 
> 
> > On Feb. 5, 2013, 8:17 a.m., Koushik Das wrote:
> > > vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java,
> > > line 475
> > > <https://reviews.apache.org/r/9196/diff/1/?file=254259#file254259lin
> > > e475>
> > >
> > >     Not used
> 
> Removed it.
> 
> 
> > On Feb. 5, 2013, 8:17 a.m., Koushik Das wrote:
> > > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.jav
> > > a, line 29
> > > <https://reviews.apache.org/r/9196/diff/1/?file=254260#file254260lin
> > > e29>
> > >
> > >     Make vmwaredvs, nexusdvs, vmwaresvs as constants
> 
> Added constants.
> 
> 
> - Sateesh
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/#review16096
> -----------------------------------------------------------
> 
> 
> On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9196/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 5, 2013, 5:41 a.m.)
> >
> >
> > Review request for cloudstack, Murali Reddy and Kelven Yang.
> >
> >
> > Description
> > -------
> >
> > This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> > This patch contains few helper functions (get dvswitch reference, check the
> type of a port group). Also added method getType() to VirtualSwitchType enum.
> >
> >
> > This addresses bug CLOUDSTACK-657.
> >
> >
> > Diffs
> > -----
> >
> >   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
> eb10e16
> >   vmware-
> base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
> >   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
> > 47ff8e2
> >
> > Diff: https://reviews.apache.org/r/9196/diff/
> >
> >
> > Testing
> > -------
> >
> > Manual testing:-
> > 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this
> case management and public traffic uses standard vSwitch on a common
> physical network.
> > 2) Tested both guest traffic and public traffic over dvSwitch on a physical
> network.
> > 3) Use optional parameters added to AddClusterCmd to override Zone level
> network traffic label. Tested 2 clusters, one with standard vSwitch and other
> with dvSwitch.
> > 4) Tested all 3 traffic types on single physical network with global parameter
> 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> >
> >
> > Added following tests,
> > 1) Test fetching dvSwitch object from vCenter
> > 2) Test for presence of dvPortGroup
> > 3) Test presence of dvPortGroup
> > 4) Test get existing dvPortGroup
> > 5) fetch dvPortGroup configuration
> > 6) Test compare dvPortGroup configuration
> > 7) Test update dvPortGroup configuration
> >
> >
> > Thanks,
> >
> > Sateesh Chodapuneedi
> >
> >

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

> On Feb. 5, 2013, 8:17 a.m., Koushik Das wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java, line 475
> > <https://reviews.apache.org/r/9196/diff/1/?file=254259#file254259line475>
> >
> >     Not used

Removed it.


> On Feb. 5, 2013, 8:17 a.m., Koushik Das wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java, line 29
> > <https://reviews.apache.org/r/9196/diff/1/?file=254260#file254260line29>
> >
> >     Make vmwaredvs, nexusdvs, vmwaresvs as constants

Added constants.


- Sateesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review16096
-----------------------------------------------------------


On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:41 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 
> 
> Diff: https://reviews.apache.org/r/9196/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>

RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by "Musayev, Ilya" <im...@webmd.net>.
Please disregard, I realized I was missing the other 4 patches out of 5.

FYI, patch 2 did not apply cleanly to current master branch and had to be done manually.

Thanks,

Regards
ilya

-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net] 
Sent: Tuesday, February 05, 2013 3:18 PM
To: cloudstack-dev@incubator.apache.org; Koushik Das; Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi
Subject: RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Sateesh,

Dont know if it makes a difference, but i went ahead and pulled the patch of review board to try it out.

My maven build failed like so:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure: Compilation failure:
[ERROR] VmwareTrafficLabel.java:[50,48] cannot find symbol [ERROR] symbol  : method getType(java.lang.String) [ERROR] location: class com.cloud.hypervisor.vmware.mo.VirtualSwitchType
[ERROR] VmwareTrafficLabel.java:[53,32] cannot find symbol [ERROR] symbol  : variable None [ERROR] location: class com.cloud.hypervisor.vmware.mo.VirtualSwitchType
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure


What am i missing?

Thanks
ilya


________________________________________
From: Koushik Das [noreply@reviews.apache.org] on behalf of Koushik Das [koushik.das@citrix.com]
Sent: Tuesday, February 05, 2013 3:17 AM
To: Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das
Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review16096
-----------------------------------------------------------



vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
<https://reviews.apache.org/r/9196/#comment34427>

    Not used



vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java
<https://reviews.apache.org/r/9196/#comment34430>

    Make vmwaredvs, nexusdvs, vmwaresvs as constants


- Koushik Das


On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:41 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 
> 47ff8e2
>
> Diff: https://reviews.apache.org/r/9196/diff/
>
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>

RE: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by "Musayev, Ilya" <im...@webmd.net>.
Sateesh,

Dont know if it makes a difference, but i went ahead and pulled the patch of review board to try it out.

My maven build failed like so:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure: Compilation failure:
[ERROR] VmwareTrafficLabel.java:[50,48] cannot find symbol
[ERROR] symbol  : method getType(java.lang.String)
[ERROR] location: class com.cloud.hypervisor.vmware.mo.VirtualSwitchType
[ERROR] VmwareTrafficLabel.java:[53,32] cannot find symbol
[ERROR] symbol  : variable None
[ERROR] location: class com.cloud.hypervisor.vmware.mo.VirtualSwitchType
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure


What am i missing?

Thanks
ilya


________________________________________
From: Koushik Das [noreply@reviews.apache.org] on behalf of Koushik Das [koushik.das@citrix.com]
Sent: Tuesday, February 05, 2013 3:17 AM
To: Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das
Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review16096
-----------------------------------------------------------



vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
<https://reviews.apache.org/r/9196/#comment34427>

    Not used



vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java
<https://reviews.apache.org/r/9196/#comment34430>

    Make vmwaredvs, nexusdvs, vmwaresvs as constants


- Koushik Das


On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:41 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
>
> Diff: https://reviews.apache.org/r/9196/diff/
>
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>

Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch in CloudStack'.

Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9196/#review16096
-----------------------------------------------------------



vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
<https://reviews.apache.org/r/9196/#comment34427>

    Not used



vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java
<https://reviews.apache.org/r/9196/#comment34430>

    Make vmwaredvs, nexusdvs, vmwaresvs as constants


- Koushik Das


On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9196/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:41 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Kelven Yang.
> 
> 
> Description
> -------
> 
> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'.
> This patch contains few helper functions (get dvswitch reference, check the type of a port group). Also added method getType() to VirtualSwitchType enum.
> 
> 
> This addresses bug CLOUDSTACK-657.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java eb10e16 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 
> 
> Diff: https://reviews.apache.org/r/9196/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
> 
> 
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>