[GitHub] [beam] jrmccluskey commented on a diff in pull request #25569: Give an option to override the number of shards in BQ streaming insert addresses

["jrmccluskey (via GitHub)" <gi...@apache.org>]

jrmccluskey commented on code in PR #25569:
URL: https://github.com/apache/beam/pull/25569#discussion_r1114882334


##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1641,6 +1639,7 @@ def __init__(
       ignore_insert_ids,
       ignore_unknown_columns,
       with_auto_sharding,
+      num_streaming_keys,

Review Comment:
   Is there a reason you don't have the old default value set here? It would help mitigate issues with backwards compatibility for users who aren't using the `test_client` and `max_retries` args either



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org