[GitHub] [hive] kgyrtkirk commented on a change in pull request #734: Hive 22028 Clean up Add Partition

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #734: Hive 22028 Clean up Add Partition
URL: https://github.com/apache/hive/pull/734#discussion_r306284100
 
 

 ##########
 File path: ql/src/test/results/clientpositive/drop_partitions_filter.q.out
 ##########
 @@ -33,8 +33,20 @@ STAGE DEPENDENCIES:
 STAGE PLANS:
   Stage: Stage-0
     Add Partition
-#### A masked pattern was here ####
-      Spec: {c=US, d=1}
+      db name: default
+      partitions:
+          Partition
+            params:
+              COLUMN_STATS_ACCURATE {"BASIC_STATS":"true","COLUMN_STATS":{"a":"true","b":"true"}}
+              numFiles 0
+              numFilesErasureCoded 0
+              numRows 0
+              rawDataSize 0
+              totalSize 0
+            partition spec:
+              c US
 
 Review comment:
   I think people got used to reading this info in explains like this format; if the partition have multiple keys;
   right now it will get split into multiple rows - and will make it harder to search for a specific partition
   
   but anyway: if we would like to change the format how we describe/reference partitions - that should be done as a whole - and not only for addpartition

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org