. ...)
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Werner Punz reopened MYFACES-2904:
----------------------------------
Ok sorry for the delay, but I was bound by customer projects, I reevaluated the code, there were bugs in the ie part of things, I cleaned up the code it should work now, I will commit my working codebase, but the table part needs further testing on my side.
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2904) javascript _Dom._outerHtml does not
handle table items (,
. ...)
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated MYFACES-2904:
------------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 2.0.2-SNAPSHOT
Resolution: Fixed
Ok, thanks Werner for check this one.
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2904) javascript _Dom._outerHtml does
not handle table items (,
. ...)
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905817#action_12905817 ]
Werner Punz commented on MYFACES-2904:
--------------------------------------
No problem thanks for merging it in, I am currently bound by customer projects so I would not have had time before next week to do it. I will give it a final testing next week to make sure the code is waterproof but from a first look it looked very good to me.
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2904) javascript _Dom._outerHtml does
not handle table items (,
. ...)
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905465#action_12905465 ]
Jakob Korherr commented on MYFACES-2904:
----------------------------------------
great stuff :)
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2904) javascript _Dom._outerHtml does not
handle table items (,
. ...)
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Werner Punz resolved MYFACES-2904.
----------------------------------
Resolution: Fixed
ok I gave the fixup code now a testrun, leos code with my fixes now work perfectly.
The Sieve test does not show any problems. Seems like the fix works.
Also table element replacement now seems to work like a charm.
Thanks Leo for providing the fix.
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2904) javascript _Dom._outerHtml does
not handle table items (,
. ...)
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905447#action_12905447 ]
Werner Punz commented on MYFACES-2904:
--------------------------------------
Wow now this is a nice patch, I never intented the outerHTML to be used this way and yes there are problems with IE. All I can say is wow... go ahead and commit it otherwise I will do :-)
Really nice stuff, thanks for doing it, I guess we now have a kickass outerHTML function.
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2904) javascript _Dom._outerHtml does not
handle table items (,
. ...)
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated MYFACES-2904:
------------------------------------
Status: Patch Available (was: Open)
> javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)
> ---------------------------------------------------------------------------
>
> Key: MYFACES-2904
> URL: https://issues.apache.org/jira/browse/MYFACES-2904
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Attachments: MYFACES-2904-1.patch
>
>
> Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.