You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@asterixdb.apache.org by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org> on 2015/12/17 23:14:17 UTC

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/558

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/indexing/dataflow/HDFSLookupAdapterFactory.java
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
106 files changed, 971 insertions(+), 1,435 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/1


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 13:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/708/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

abdullah alamoudi has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 11:

Hi Steven,
I read the previous comments and saw the statement about the tests duplicating the work.

Can you point out for every test which existing test cases covers them already?. Just want to be safe.

Other than this, I am good with this change.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 10: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/671/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 2: Verified-1

Build Failed 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/635/ : ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org>.

Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 8:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql:

Line 23
> This is one of the redundant tests. It's already tested in the datatype fol
Why do you keep it in the metadata testsuite in this case?


https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java:

Line 59:                 // Get datatype that uses this anonymous datatype (there is only one)
> This is still used for reading metadata primary index tuples
Where exactly?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 8: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/668/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello abdullah alamoudi, Ildar Absalyamov, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#13).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes
User-facing changes are:
1) Allow qualified datatype when creating dataset
2) Metadata queries for datasets will now
include the type dataverse

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
M asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
M asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20/meta20.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21/meta21.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta22/meta22.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta23/meta23.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndexImmutableProperties.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
132 files changed, 807 insertions(+), 1,553 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/13
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Ildar Absalyamov, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#11).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
M asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
M asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20/meta20.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21/meta21.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta22/meta22.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta23/meta23.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
131 files changed, 824 insertions(+), 1,548 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#8).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
116 files changed, 800 insertions(+), 1,275 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

abdullah alamoudi has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 10:

Steven,
Before you merge, let me take a look

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org>.

Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 1:

(15 comments)

Following our conversation on Tuesday I believe the static field offset constants for in *TupleTranalators are not needed. 
Those constants are not duplicates of the constants in MetadataRecordTypes either. The payload offset in each in the translators is numerically equal to number of primary keys for particular dataset, which is statically assigned in MetadataPrimaryIndexes. Neither of offsets other than payload are used, so I thinks since we're there we can refactor this code

https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql:

Line 24
Why all these tests were deleted?


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql:

Line 33: use dataverse teacher;
If we can use fully qualified name for types/dataset is there still a need for use statement?


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql:

Line 28: use dataverse teacher;
Same here


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
File asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm:

Line 1: { "DataverseName": "student", "DatasetName": "gdstd", "DatatypeDataverseName": "student", "DatatypeName": "stdType", "DatasetType": "INTERNAL", "GroupName": "DEFAULT_NG_ALL_NODES", "CompactionPolicy": "prefix", "CompactionPolicyProperties": [ { "Name": "max-mergable-component-size", "Value": "1073741824" }, { "Name": "max-tolerance-component-count", "Value": "5" } ], "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ [ "id" ] ], "PrimaryKey": [ [ "id" ] ], "Autogenerated": false }, "ExternalDetails": null, "Hints": {{  }}, "Timestamp": "Thu Dec 17 12:58:43 PST 2015", "DatasetId": 118i32, "PendingOp": 0i32 }
Why dataset IDs changed here, but not in the previous test case?


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-lang-aql/src/main/javacc/AQL.jj
File asterix-lang-aql/src/main/javacc/AQL.jj:

Line 422:     <LEFTPAREN> typeComponents = TypeName() <RIGHTPAREN>
Documentation, describing AQL should be updated accordingly


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java:

Line 719:     private boolean confirmDataverseCanBeDeleted(JobId jobId, String dataverseName)
Seems like the method does not need to return anything.


Line 737:     private boolean confirmDatatypeIsUnused(JobId jobId, String dataverseName, String datatypeName)
Same here


Line 743:     private boolean confirmDatatypeIsUnusedByDatasets(JobId jobId, String dataverseName, String datatypeName)
And here


Line 756:     private boolean confirmDatatypeIsUnusedByDatatypes(JobId jobId, String dataverseName, String datatypeName)
And here


Line 775:     public String getDatatypeNameUsingThisAnonymousDatatype(JobId jobId, String dataverseName, String datatypeName)
The method has nothing specific to anonymous types, right?


Line 781:         if (dataverseDatatypes != null && dataverseDatatypes.size() > 0) {
This if statement is completely redundant here, getDataverseDatatypes() does not return null, and the 2nd part of the predicate is redundant


Line 795:     private List<String> getNestedDatatypeNamesForThisDatatype(JobId jobId, String dataverseName, String datatypeName)
The name of the method should imply that the returned datatypes are complex rather then builtin


Line 802:             if (!(subType instanceof BuiltinType)) {
Use typeTags here instead of "instanceof"


Line 816:                 nodeGroupDatasets.add(new Pair<String, String>(set.getDataverseName(), set.getDatasetName()));
I am generally concerned about generating all those intermediate Pair<> objects. If the only thing they are designed for is to carry information about dataverse+dataset, then we need to refactor how this infomation is stored in Dataset object. Maybe it's worth to introduce nested object


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java:

Line 59:                 // Get index 0 because it is anonymous type, and it is used in
Comment seems to be not valid anymore.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#6).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
112 files changed, 804 insertions(+), 1,271 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has submitted this change and it was merged.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes
User-facing changes are:
1) Allow qualified datatype when creating dataset
2) Metadata queries for datasets will now
include the type dataverse

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Reviewed-on: https://asterix-gerrit.ics.uci.edu/558
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <ba...@gmail.com>
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
M asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
M asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20/meta20.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21/meta21.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta22/meta22.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta23/meta23.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-dataverse/drop-dataverse.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndexImmutableProperties.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
137 files changed, 797 insertions(+), 1,576 deletions(-)

Approvals:
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified




-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#2).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-external-data/src/main/java/org/apache/asterix/external/indexing/dataflow/HDFSLookupAdapterFactory.java
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
106 files changed, 986 insertions(+), 1,448 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 9:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/670/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 14:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/709/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/626/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#9).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
117 files changed, 798 insertions(+), 1,360 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 10:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/671/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#10).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
M asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
M asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20/meta20.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21/meta21.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta22/meta22.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta23/meta23.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
130 files changed, 826 insertions(+), 1,536 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 7: Verified-1

Build Failed 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/667/ : ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 11: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/676/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org>.

Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 10: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 13: Verified-1

Build Unstable 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/708/ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 9:

(1 comment)

Fixed test ordering

https://asterix-gerrit.ics.uci.edu/#/c/558/9/asterix-app/src/test/resources/metadata/testsuite.xml
File asterix-app/src/test/resources/metadata/testsuite.xml:

Line 196
> OK, but what about test cases 20&21? It seems they are the same as 'metadat
I feel like keeping the numbers is the wrong choice because it's making the tests strictly less descriptive. So I took out 20 and 21 and moved 22 and 23 to be 16 and 17


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 1: Verified-1

Build Unstable 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/626/ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

abdullah alamoudi has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Patch Set 10:

(11 comments)

Hi Steven,
Some small comments. Please have a look.
My biggest concern is the deletion of the test cases.

In addition, one of the rules for (introduce access methods), it checks if the secondary index is a metadata index and then skips it if it is. can we remove that check since it doesn't make sense anymore?

Thanks,
Abdullah.

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
File asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java:

Line 254: * =======
Conflict was not resolved correctly.
Please, fix.

Line 293: * <<<<<<< HEAD
Conflict was not resolved correctly.
please, fix.

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql:

Line 19: /*
why was meta16 test changed instead of creating a new test?

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql:

Line 23: */
why change this instead of keeping it and creating a new one?

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql:

Line 17
why delete a test case? does it still pass?

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql:

Line 17
why deleting this test case too?

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql:

Line 17
why deleting this test case as well.

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql:

Line 17
why deleting the test case as well?

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java:

Line 731: throws MetadataException, RemoteException {
Please, add a failing test case for this one.

Line 743: throws MetadataException, RemoteException {
This method has a bunch of issues:
1. you need to take the subdata type item and break it into its two components (dataverse name and data type name). then check and make sure that the dataverse of the subtype == the dataverse of the type to be deleted.

2. the way this is implemented means all the types will be loaded in memory. if the system was used for a very long time, then the memory cost of this will be too much. I know this is right now is done like this everywhere. can you please add a todo for this?

3. Did you add test cases to test this failure scenario? do some with fully qualified names and some without.

4. the error message in the exception is not correct. the second dataverse name should be the dataverse name of the other data type.

https://asterix-gerrit.ics.uci.edu/#/c/558/10/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java:

Line 2055: *
white space.

--
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#4).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
104 files changed, 774 insertions(+), 1,223 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 14:

I removed the three lines, and updated the tests to fit with the new test structure.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 12:

Is this good to merge now?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#3).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-external-data/src/main/java/org/apache/asterix/external/indexing/dataflow/HDFSLookupAdapterFactory.java
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
105 files changed, 986 insertions(+), 1,425 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 3: Verified-1

Build Failed 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/648/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/664/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 14: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/709/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 3: -Verified

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/648/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 9: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/670/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 12:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/679/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 3: Verified-1

Build Unstable 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/636/ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 4: Verified-1

Build Failed 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/662/ : ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 11:

(4 comments)

@Abdullah:
The tests 16-21 corresponded in order to tests dataset, datatype, dataverse, index, node, and node group. I moved 22 and 23 to be 16 and 17, which makes the code review look bonkers

@Till:
Those two are all of the user-side changes. I will add them to the commit message. I think a QualifiedName type is a VERY good idea

I think I've addressed the lingering issues. I'm uploading a new patchset now

https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
File asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java:

Line 253:      * 
> WS
Done


Line 290:      * 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
File asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java:

Line 84:     public String getPrettyTypeName() {
> getQualifiedName?
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java:

Line 762:     public String getDatatypeNameUsingThisAnonymousDatatype(JobId jobId, String dataverseName, String datatypeName)
> Where is this method needed/used?
This was being used in Patchset 1, but is no longer needed. Good Catch! I'll delete it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 12: Verified+1

Build Successful 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/679/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.

Till Westmann has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 11: Code-Review+1

(4 comments)

Looks generally good to me. I've got one high-level question: What are the use-visible changes here? I saw
a) it is possible to provide qualified type names for datasets and
b) the metadata queries additionally return the DatatypeDataverseName for a dataset.
Is there something else? Could you maybe add the description of the user-visible changes to the commit message?

(Also, reading the code, it seemed to me that some things would be easier to read if we had the concept of a "qualified name" - both in Java and in the metadata entries. But this is not a request to add that in this change - we'd need a bigger discussion before we did that :) )

https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
File asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java:

Line 253:      * 
WS


Line 290:      * 
WS


https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
File asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java:

Line 84:     public String getPrettyTypeName() {
getQualifiedName?


https://asterix-gerrit.ics.uci.edu/#/c/558/11/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java:

Line 762:     public String getDatatypeNameUsingThisAnonymousDatatype(JobId jobId, String dataverseName, String datatypeName)
Where is this method needed/used?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Ildar Absalyamov, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#12).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes
User-facing changes are:
1) Allow qualified datatype when creating dataset
2) Metadata queries for datasets will now
include the type dataverse

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
M asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
M asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20/meta20.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21/meta21.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta22/meta22.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta23/meta23.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
131 files changed, 806 insertions(+), 1,549 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org>.

Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 9:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/558/9/asterix-app/src/test/resources/metadata/testsuite.xml
File asterix-app/src/test/resources/metadata/testsuite.xml:

Line 196
OK, but what about test cases 20&21? It seems they are the same as 'metadata_node' and 'metadata_nodegroup'.
On contrary I suggest removing named test cases because doing otherwise breaks the naming scheme (there will be a gap between 15 and 22)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 5: Verified-1

Build Failed 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/663/ : ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Preston Carman (Code Review)" <do...@asterixdb.incubator.apache.org>.

Preston Carman has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 1:

(11 comments)

https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql:

Line 22:  				: Try dropping the foreign type's dataverse
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql:

Line 22:  				: Try dropping the foreign type's dataverse
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql:

Line 22:  				: Try dropping the foreign datatype
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql:

Line 22:  				: Try dropping the foreign datatype
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql:

Line 22:  				: Try dropping the dataset
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql:

Line 22:  				: Try dropping the dataset
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql:

Line 22:  				: Try dropping the dataset
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql:

Line 22:  				: Try dropping the dataset
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql:

Line 23:  * Expected Res : Success
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql:

Line 22:  				: Query the dataset
Remove tabs.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql:

Line 22:  				: Query the dataset
Remove tabs.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

abdullah alamoudi has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 14: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Patch Set 8:

(2 comments)

Addressed comments. Uploading a new patch set.

https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql:

Line 23
> Why do you keep it in the metadata testsuite in this case?
Interesting. I didn't realize that there was a test suite. It seems to work with the files missing for some reason. I guess I'll remove them anyway.

https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java:

Line 59: // Get datatype that uses this anonymous datatype (there is only one)
> Where exactly?
You were right. I was mixing up the extractors. I'll remove it.

--
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 8:

This branch is finally building and ready for re-review

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 8:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/668/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org>.

Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 8:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql:

Line 23
Why is this file removed?


https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql:

Line 22
Why is this file removed?


https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java:

Line 59:                 // Get datatype that uses this anonymous datatype (there is only one)
Seems like this data extractor is not used by anyone, since the secondary metadata "indices" are removed, right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/662/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#7).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
112 files changed, 800 insertions(+), 1,267 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 11:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/676/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/635/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

abdullah alamoudi has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 12: Code-Review+2

Steven,
I think this change is good to go. One thing and feel free to change it now or later. In MetadataIndexImmutableProperties, line 37, 38, 39, three enumerations that were only used with secondary indexes in metadata. they are not used anymore and they should be deleted.

Cheers,
Abdullah.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Patch Set 10:

(5 comments)

I think I addressed all of your concerns. My two big comments:

1) Please see previous code review comments for full discussions on tests, but the summary is that I found and removed duplicate test files from Meta data tests

2) Please note that this review doesn't allow types to use foreign types. Maybe this is something that someone would want later but it's not considered here.

I am posting the new patchset now

Line 254: * =======
> Conflict was not resolved correctly.
Done

Line 293: * <<<<<<< HEAD
> Conflict was not resolved correctly.
Done

Line 731: throws MetadataException, RemoteException {
> Please, add a failing test case for this one.
They are already in this review. I have one for dropping a type used within the same dataverse and one for dropping a type used by another dataverse

Line 743: throws MetadataException, RemoteException {
> This method has a bunch of issues:
1. This code change doesn't allow types to use foreign types, but only datasets to use foreign types, so it's not an issue yet
2. Added a TODO
3. I did add a test case. Once again, types are still not allowed to use foreign subtypes
4. They will always be the same for now.

Line 2055: *
> white space.
Done

--
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org>.

Ildar Absalyamov has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 10: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#5).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
D asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
108 files changed, 776 insertions(+), 1,241 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello abdullah alamoudi, Ildar Absalyamov, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/558

to look at the new patch set (#14).

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................

Enabled Datasets to use Datatypes from foreign Dataverses

Removed broken Metadata Secondary Indexes
Added DatatypeDataverse field to Dataset
Cleaned up Metadata Tests
Added tests for dropping used Datatypes
User-facing changes are:
1) Allow qualified datatype when creating dataset
2) Metadata queries for datasets will now
include the type dataverse

Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
---
M asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M asterix-app/src/main/java/org/apache/asterix/file/ExternalIndexingOperations.java
M asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.1.ddl.aql
M asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta19/meta19.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta20/meta20.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta21/meta21.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.2.update.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta22/meta22.3.query.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.1.ddl.aql
D asterix-app/src/test/resources/metadata/queries/basic/meta23/meta23.2.update.aql
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
D asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4.adm
M asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta01.adm
D asterix-app/src/test/resources/metadata/results/basic/meta02.adm
M asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta03.adm
D asterix-app/src/test/resources/metadata/results/basic/meta04.adm
D asterix-app/src/test/resources/metadata/results/basic/meta05.adm
D asterix-app/src/test/resources/metadata/results/basic/meta06.adm
D asterix-app/src/test/resources/metadata/results/basic/meta07.adm
D asterix-app/src/test/resources/metadata/results/basic/meta08.adm
D asterix-app/src/test/resources/metadata/results/basic/meta09.adm
M asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta10.adm
D asterix-app/src/test/resources/metadata/results/basic/meta11.adm
D asterix-app/src/test/resources/metadata/results/basic/meta12.adm
D asterix-app/src/test/resources/metadata/results/basic/meta13.adm
D asterix-app/src/test/resources/metadata/results/basic/meta14.adm
D asterix-app/src/test/resources/metadata/results/basic/meta15.adm
D asterix-app/src/test/resources/metadata/results/basic/meta16.adm
M asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta17.adm
M asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18.adm
D asterix-app/src/test/resources/metadata/results/basic/meta18/meta18.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19.adm
D asterix-app/src/test/resources/metadata/results/basic/meta19/meta19.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20.adm
D asterix-app/src/test/resources/metadata/results/basic/meta20/meta20.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21.adm
D asterix-app/src/test/resources/metadata/results/basic/meta21/meta21.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta22/meta22.1.adm
D asterix-app/src/test/resources/metadata/results/basic/meta23/meta23.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataset.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_datatype.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_index.adm
M asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_node.adm
D asterix-app/src/test/resources/metadata/results/basic/metadata_nodegroup.adm
M asterix-app/src/test/resources/metadata/testsuite.xml
M asterix-app/src/test/resources/parserts/queries_sqlpp/del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/queries_sqlpp/load-del-dataset.sqlpp
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/del-dataset.ast
M asterix-app/src/test/resources/parserts/results_parser_sqlpp/load-del-dataset.ast
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv03/cross-dv03.1.ddl.aql
M asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv04/cross-dv04.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
C asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
R asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.update.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-dataverse/drop-dataverse.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.adm
A asterix-app/src/test/resources/runtimets/results/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.adm
M asterix-app/src/test/resources/runtimets/results/dml/drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.adm
M asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv01/cross-dv01.2.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv03/cross-dv03.1.ast
M asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv04/cross-dv04.1.ast
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-doc/src/site/markdown/aql/manual.md
M asterix-lang-aql/src/main/javacc/AQL.jj
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndexImmutableProperties.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataSecondaryIndexes.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/MetadataBuiltinFunctions.java
M asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatasetNameValueExtractor.java
D asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
137 files changed, 797 insertions(+), 1,576 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/558/14
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/636/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 8:

(3 comments)

Addressed comments. No changes required so far

https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql:

Line 23
> Why is this file removed?
This is one of the redundant tests. It's already tested in the datatype folder


https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql:

Line 22
> Why is this file removed?
Same


https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java:

Line 59:                 // Get datatype that uses this anonymous datatype (there is only one)
> Seems like this data extractor is not used by anyone, since the secondary m
This is still used for reading metadata primary index tuples


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/663/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.

Steven Jacobs has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 1:

(26 comments)

I addressed comments, and I am uploading my change. Hopefully it will build this time :(

https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql
File asterix-app/src/test/resources/metadata/queries/basic/meta16/meta16.3.query.aql:

Line 24
> Why all these tests were deleted?
I discovered that these tests really duplicate the work done by other tests, specifically, the tests called dataset, datatype, dataverse.


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.1.ddl.aql:

Line 33: use dataverse teacher;
> If we can use fully qualified name for types/dataset is there still a need 
In this test the last two statements don't have paths on the type usage (tchrType) meaning that they will use the teacher dataverse


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv01/cross-dv01.2.update.aql:

Line 28: use dataverse teacher;
> Same here
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql:

Line 22:  				: Try dropping the foreign type's dataverse
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.2.update.aql:

Line 22:  				: Try dropping the foreign type's dataverse
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.1.ddl.aql:

Line 22:  				: Try dropping the foreign datatype
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-elsewhere/drop-type-used-elsewhere.2.update.aql:

Line 22:  				: Try dropping the foreign datatype
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.1.ddl.aql:

Line 22:  				: Try dropping the dataset
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-dataset/drop-type-used-here-dataset.2.update.aql:

Line 22:  				: Try dropping the dataset
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.1.ddl.aql:

Line 22:  				: Try dropping the dataset
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-type-used-here-type/drop-type-used-here-type.2.update.aql:

Line 22:  				: Try dropping the dataset
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.1.ddl.aql:

Line 23:  * Expected Res : Success
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.2.update.aql:

Line 22:  				: Query the dataset
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql
File asterix-app/src/test/resources/runtimets/queries/cross-dataverse/query-dataset-with-foreign-type/query-dataset-with-foreign-type.3.query.aql:

Line 22:  				: Query the dataset
> Remove tabs.
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
File asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm:

Line 1: { "DataverseName": "student", "DatasetName": "gdstd", "DatatypeDataverseName": "student", "DatatypeName": "stdType", "DatasetType": "INTERNAL", "GroupName": "DEFAULT_NG_ALL_NODES", "CompactionPolicy": "prefix", "CompactionPolicyProperties": [ { "Name": "max-mergable-component-size", "Value": "1073741824" }, { "Name": "max-tolerance-component-count", "Value": "5" } ], "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ [ "id" ] ], "PrimaryKey": [ [ "id" ] ], "Autogenerated": false }, "ExternalDetails": null, "Hints": {{  }}, "Timestamp": "Thu Dec 17 12:58:43 PST 2015", "DatasetId": 118i32, "PendingOp": 0i32 }
> Why dataset IDs changed here, but not in the previous test case?
I think this is because the changes I made to these existing queries did alter the results slightly. Previously, the assumption seems to have been "The datatype will always be from the same dataverse as specified by the dataset qualified name" But this seems incorrect now that we allow qualified datatype usage. So now the assumption is "If the datatype wasn't qualified, then it should be from the currently used dataverse"


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-lang-aql/src/main/javacc/AQL.jj
File asterix-lang-aql/src/main/javacc/AQL.jj:

Line 422:     <LEFTPAREN> typeComponents = TypeName() <RIGHTPAREN>
> Documentation, describing AQL should be updated accordingly
Done


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java:

Line 719:     private boolean confirmDataverseCanBeDeleted(JobId jobId, String dataverseName)
> Seems like the method does not need to return anything.
Done


Line 737:     private boolean confirmDatatypeIsUnused(JobId jobId, String dataverseName, String datatypeName)
> Same here
Done


Line 743:     private boolean confirmDatatypeIsUnusedByDatasets(JobId jobId, String dataverseName, String datatypeName)
> And here
Done


Line 756:     private boolean confirmDatatypeIsUnusedByDatatypes(JobId jobId, String dataverseName, String datatypeName)
> And here
Done


Line 775:     public String getDatatypeNameUsingThisAnonymousDatatype(JobId jobId, String dataverseName, String datatypeName)
> The method has nothing specific to anonymous types, right?
Yes, because it only returns a single type. If called on a non anonymous type, it would return only the "first" type using this type, which is not really valid information


Line 781:         if (dataverseDatatypes != null && dataverseDatatypes.size() > 0) {
> This if statement is completely redundant here, getDataverseDatatypes() doe
You are right. I had copied this from elsewhere in this file, so I removed it there as well.


Line 795:     private List<String> getNestedDatatypeNamesForThisDatatype(JobId jobId, String dataverseName, String datatypeName)
> The name of the method should imply that the returned datatypes are complex
Done


Line 802:             if (!(subType instanceof BuiltinType)) {
> Use typeTags here instead of "instanceof"
I'm not sure how. There are many different potential type tags that are all builtin


Line 816:                 nodeGroupDatasets.add(new Pair<String, String>(set.getDataverseName(), set.getDatasetName()));
> I am generally concerned about generating all those intermediate Pair<> obj
Mike said that we shouldn't really be thinking about optimizing this use case, so I think altering the metadata would be a mistake. There is a much simpler solution. This check is only used to see whether a node group can be deleted, so it doesn't matter too much where the datasets come from, just that they exist. I'll make this change and see if you are okey with the new version


https://asterix-gerrit.ics.uci.edu/#/c/558/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java:

Line 59:                 // Get index 0 because it is anonymous type, and it is used in
> Comment seems to be not valid anymore.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 6: Verified-1

Build Unstable 

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/664/ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Enabled Datasets to use Datatypes from foreign Dataverses

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: Enabled Datasets to use Datatypes from foreign Dataverses
......................................................................


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/667/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/558
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No